linux-kernel - Re: [PATCH 3/3] Staging: rtl8192u: r8192U_core.c: Replace memcpy with eth_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <55EC9669.5@lwfinger.net>
Date:	Sun, 6 Sep 2015 14:39:21 -0500
From:	Larry Finger <Larry.Finger@...inger.net>
To:	Shraddha Barke <shraddha.6596@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
	Mateusz Kulikowski <mateusz.kulikowski@...il.com>,
	Aya Mahfouz <mahfouz.saif.elyazal@...il.com>,
	Julia Lawall <julia.lawall@...6.fr>,
	Sudip Mukherjee <sudipm.mukherjee@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] Staging: rtl8192u: r8192U_core.c: Replace memcpy with
 eth_addr_copy

On 09/06/2015 02:04 PM, Shraddha Barke wrote:
> This patch replaces memcpy with eth_addr_copy
>
> The changes were applied using the following coccinelle
> rule:
> @@ expression e1, e2; @@
> - memcpy(e1, e2, ETH_ALEN);
> + ether_addr_copy(e1, e2);
>
> Signed-off-by: Shraddha Barke <shraddha.6596@...il.com>
> ---
>   drivers/staging/rtl8192u/r8192U_core.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c
> index 6f6fe38..577d3a4 100644
> --- a/drivers/staging/rtl8192u/r8192U_core.c
> +++ b/drivers/staging/rtl8192u/r8192U_core.c
> @@ -3430,7 +3430,7 @@ static int r8192_set_mac_adr(struct net_device *dev, void *mac)
>
>   	down(&priv->wx_sem);
>
> -	memcpy(dev->dev_addr, addr->sa_data, ETH_ALEN);
> +	ether_addr_copy(dev->dev_addr, addr->sa_data);
>
>   	schedule_work(&priv->reset_wq);
>   	up(&priv->wx_sem);
>

This patch has the same problems as do both patches 1 and 2.

NACK.

Larry

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/