linux-kernel - Re: [PATCH v7 2/3] KVM: dynamic halt-polling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BLU437-SMTP95034C0E9A98D5DBDFEB3A80550@phx.gbl>
Date:	Mon, 7 Sep 2015 06:23:35 +0800
From:	Wanpeng Li <wanpeng.li@...mail.com>
To:	Paolo Bonzini <pbonzini@...hat.com>
CC:	David Matlack <dmatlack@...gle.com>, kvm@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7 2/3] KVM: dynamic halt-polling

On 9/6/15 10:32 PM, Paolo Bonzini wrote:
>
> On 05/09/2015 00:38, Wanpeng Li wrote:
>>> @@ -1940,11 +1975,16 @@ void kvm_vcpu_block(struct kvm_vcpu *vcpu)
>>>                 * arrives.
>>>                 */
>>>                if (kvm_vcpu_check_block(vcpu) < 0) {
>>> +                polled = true;
>>>                    ++vcpu->stat.halt_successful_poll;
>>> -                goto out;
>>> +                break;
>>>                }
>>>                cur = ktime_get();
>>>            } while (single_task_running() && ktime_before(cur, stop));
>>> +
>>> +        poll_ns = ktime_to_ns(cur) - ktime_to_ns(start);
>>> +        if (polled)
>>> +            goto out;
>>>
>> Please move poll_ns caculation under if() when you applied, as I
>> explained in reply to v6.
> You can do much more than just that, the patch reduces to this:
>

Cool, many thanks for your help, Paolo! :)

Regards,
Wanpeng Li
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/