linux-kernel - Re: [PATCH v2 4/4] sched/numa: Convert sched_numa_balancing to a static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 6 Sep 2015 12:01:10 +0800
From:	Wanpeng Li <wanpeng.li@...mail.com>
To:	Srikar Dronamraju <srikar@...ux.vnet.ibm.com>,
	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>
CC:	linux-kernel@...r.kernel.org, Rik van Riel <riel@...hat.com>,
	Mel Gorman <mgorman@...e.de>
Subject: Re: [PATCH v2 4/4] sched/numa: Convert sched_numa_balancing to a
 static_branch

Hi Srikar,
On 8/12/15 12:24 AM, Srikar Dronamraju wrote:
> Variable sched_numa_balancing toggles numa_balancing feature. Hence
> moving from a simple read mostly variable to a more apt static_branch.
>
> Suggested-by: Peter Zijlstra <peterz@...radead.org>
> Signed-off-by: Srikar Dronamraju <srikar@...ux.vnet.ibm.com>
>
This commit breaks Peter's queue:

kernel/sched/fair.c: In function ‘task_numa_fault’:
kernel/sched/fair.c:2072: error: implicit declaration of function 
‘static_branch_likely’
kernel/sched/fair.c: In function ‘task_tick_fair’:
kernel/sched/fair.c:7867: error: implicit declaration of function 
‘static_branch_unlikely’
make[1]: *** [kernel/sched/fair.o] Error 1
make[1]: *** Waiting for unfinished jobs....
kernel/sched/core.c:2116: warning: data definition has no type or 
storage class
kernel/sched/core.c:2116: error: type defaults to ‘int’ in declaration 
of ‘DEFINE_STATIC_KEY_FALSE’
kernel/sched/core.c:2116: warning: parameter names (without types) in 
function declaration
kernel/sched/core.c: In function ‘set_numabalancing_state’:
kernel/sched/core.c:2123: error: implicit declaration of function 
‘static_branch_enable’
kernel/sched/core.c:2125: error: implicit declaration of function 
‘static_branch_disable’
kernel/sched/core.c: In function ‘sysctl_numa_balancing’:
kernel/sched/core.c:2134: error: implicit declaration of function 
‘static_branch_likely’
make[1]: *** [kernel/sched/core.o] Error 1
make: *** [kernel/sched/] Error 2

Regards,
Wanpeng Li
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/