linux-kernel - Re: [PATCH 1/3] Revert "ahci: added support for Freescale AHCI sata"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55ED503E.5000902@redhat.com>
Date:	Mon, 7 Sep 2015 10:52:14 +0200
From:	Hans de Goede <hdegoede@...hat.com>
To:	Yuantian.Tang@...escale.com
Cc:	tj@...nel.org, linux-ide@...r.kernel.org,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH 1/3] Revert "ahci: added support for Freescale AHCI sata"

Hi,

On 07-09-15 10:23, Yuantian.Tang@...escale.com wrote:
> From: Tang Yuantian <Yuantian.Tang@...escale.com>
>
> This reverts commit 5163fb62541e
> ("ahci: added support for Freescale AHCI sata")
>
> The reverted patch added Freescale QorIQ AHCI sata support to
> ahci_platform driver though, but it left SoC specific settings to uboot.
> It leads to QorIQ sata heavily depending on uboot. In order to removing
> the dependency we first revert the old patch and then will add a new driver
> for QorIQ SATA.
> Since there are no LS* platforms that have been upstreamed, So
> the revert would not break anything exists.
>
> Signed-off-by: Tang Yuantian <Yuantian.Tang@...escale.com>

The entire series looks good to me and is:

Reviewed-by: Hans de Goede <hdegoede@...hat.com>

Regards,

Hans


> ---
>   Documentation/devicetree/bindings/ata/ahci-platform.txt | 2 --
>   drivers/ata/ahci_platform.c                             | 1 -
>   2 files changed, 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/ata/ahci-platform.txt b/Documentation/devicetree/bindings/ata/ahci-platform.txt
> index a232181..c2340ee 100644
> --- a/Documentation/devicetree/bindings/ata/ahci-platform.txt
> +++ b/Documentation/devicetree/bindings/ata/ahci-platform.txt
> @@ -16,8 +16,6 @@ Required properties:
>     - "snps,dwc-ahci"
>     - "snps,exynos5440-ahci"
>     - "snps,spear-ahci"
> -  - "fsl,qoriq-ahci" : for qoriq series socs which include ls1021, ls2085, etc.
> -  - "fsl,<chip>-ahci" : chip could be ls1021, ls2085 etc.
>     - "generic-ahci"
>   - interrupts        : <interrupt mapping for SATA IRQ>
>   - reg               : <registers mapping>
> diff --git a/drivers/ata/ahci_platform.c b/drivers/ata/ahci_platform.c
> index 1befb11..04975b8 100644
> --- a/drivers/ata/ahci_platform.c
> +++ b/drivers/ata/ahci_platform.c
> @@ -76,7 +76,6 @@ static const struct of_device_id ahci_of_match[] = {
>   	{ .compatible = "ibm,476gtr-ahci", },
>   	{ .compatible = "snps,dwc-ahci", },
>   	{ .compatible = "hisilicon,hisi-ahci", },
> -	{ .compatible = "fsl,qoriq-ahci", },
>   	{},
>   };
>   MODULE_DEVICE_TABLE(of, ahci_of_match);
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/