linux-kernel - Re: [PATCH v2] ARM: tegra: paz00: use con_id's to refer GPIO's in gpiod

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 7 Sep 2015 12:21:37 +0300
From:	Dmitry Osipenko <digetx@...il.com>
To:	Stephen Warren <swarren@...dotorg.org>,
	Thierry Reding <thierry.reding@...il.com>,
	Alexandre Courbot <gnurou@...il.com>,
	Marc Dietrich <marvin24@....de>
Cc:	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
	stable@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] ARM: tegra: paz00: use con_id's to refer GPIO's in
 gpiod_lookup table

30.06.2015 17:15, Dmitry Osipenko пишет:
> Commit 72daceb9a10a ("net: rfkill: gpio: Add default GPIO driver mappings
> for ACPI") removed possibility to request GPIO by table index for non-ACPI
> platforms without changing it users. As result "shutdown" GPIO request
> will fail if request for "reset" GPIO succeeded or "reset" will be
> requested instead of "shutdown" if "reset" wasn't defined. Fix it by
> making gpiod_lookup_table use con_id's instead of indexes.
>
> Signed-off-by: Dmitry Osipenko <digetx@...il.com>
> Fixes: 72daceb (net: rfkill: gpio: Add default GPIO driver mappings for ACPI)
> Cc: <stable@...r.kernel.org> # v3.19+
> Acked-by: Alexandre Courbot <acourbot@...dia.com>
> ---
>
> v2: s/GPIO_LOOKUP_IDX/GPIO_LOOKUP/, otherwise "shutdown" GPIO won't be requested
>
>   arch/arm/mach-tegra/board-paz00.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-tegra/board-paz00.c b/arch/arm/mach-tegra/board-paz00.c
> index fbe74c6..49d1110 100644
> --- a/arch/arm/mach-tegra/board-paz00.c
> +++ b/arch/arm/mach-tegra/board-paz00.c
> @@ -39,8 +39,8 @@ static struct platform_device wifi_rfkill_device = {
>   static struct gpiod_lookup_table wifi_gpio_lookup = {
>   	.dev_id = "rfkill_gpio",
>   	.table = {
> -		GPIO_LOOKUP_IDX("tegra-gpio", 25, NULL, 0, 0),
> -		GPIO_LOOKUP_IDX("tegra-gpio", 85, NULL, 1, 0),
> +		GPIO_LOOKUP("tegra-gpio", 25, "reset", 0),
> +		GPIO_LOOKUP("tegra-gpio", 85, "shutdown", 0),
>   		{ },
>   	},
>   };
>
Ping

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/