linux-kernel - Re: [PATCH V4 2/2] arm64: Change memcpy in kernel to use the copy template file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150907111351.GB10645@e104818-lin.cambridge.arm.com>
Date:	Mon, 7 Sep 2015 12:13:52 +0100
From:	Catalin Marinas <catalin.marinas@....com>
To:	Feng Kan <fkan@....com>
Cc:	patches@....com, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org,
	philipp.tomsich@...obroma-systems.com, dann.frazier@...onical.com,
	tim.gardner@...onical.com, craig.magina@...onical.com,
	soni.trilok.oss@...il.com
Subject: Re: [PATCH V4 2/2] arm64: Change memcpy in kernel to use the copy
 template file

On Fri, Aug 21, 2015 at 03:01:41PM -0700, Feng Kan wrote:
> This converts the memcpy.S to use the copy template file. The copy
> template file was based originally on the memcpy.S. Minor changes
> was made to it to accommodate the copy to/from/in user files.

I think it will be easier to follow if you make this patch the first,
just a simple move of code without any functional change.

> 
> Signed-off-by: Feng Kan <fkan@....com>
> ---
>  arch/arm64/lib/memcpy.S | 179 +++++++-----------------------------------------
>  1 file changed, 26 insertions(+), 153 deletions(-)
> 
> diff --git a/arch/arm64/lib/memcpy.S b/arch/arm64/lib/memcpy.S
> index 8a9a96d..761acd7 100644
> --- a/arch/arm64/lib/memcpy.S
> +++ b/arch/arm64/lib/memcpy.S
[...]
> +        .macro strh1 label, ptr, regB, val
> +        strh \ptr, [\regB], \val
> +        .endm

There is a problem with the tab/space conversion, either in your editor
or the email server. The above indentation should use tabs (and the
subsequent ones).

-- 
Catalin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/