linux-kernel - Re: [PATCH v2 2/2] leds: leds-ipaq-micro: Fix coding style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 07 Sep 2015 16:54:36 +0200
From:	Jacek Anaszewski <j.anaszewski@...sung.com>
To:	Muhammad Falak R Wani <falakreyaz@...il.com>
Cc:	Bryan Wu <cooloney@...il.com>, Richard Purdie <rpurdie@...ys.net>,
	linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] leds: leds-ipaq-micro: Fix coding style issues

Hi Muhammad,

On 09/07/2015 04:13 PM, Muhammad Falak R Wani wrote:
> Spaces at the starting of a line are removed, indentation
> using tab, instead of space. Also, warnings related to
> line width of more than 80 characters is also taken care of.
> Two warnings have been left alone to aid better readability.
>
> Signed-off-by: Muhammad Falak R Wani <falakreyaz@...il.com>
> ---
>   drivers/leds/leds-ipaq-micro.c | 38 +++++++++++++++++++-------------------
>   1 file changed, 19 insertions(+), 19 deletions(-)
>
> diff --git a/drivers/leds/leds-ipaq-micro.c b/drivers/leds/leds-ipaq-micro.c
> index 1206215..86716ea 100644
> --- a/drivers/leds/leds-ipaq-micro.c
> +++ b/drivers/leds/leds-ipaq-micro.c
> @@ -16,9 +16,9 @@
>   #define LED_YELLOW	0x00
>   #define LED_GREEN	0x01
>
> -#define LED_EN          (1 << 4)        /* LED ON/OFF 0:off, 1:on                       */
> -#define LED_AUTOSTOP    (1 << 5)        /* LED ON/OFF auto stop set 0:disable, 1:enable */
> -#define LED_ALWAYS      (1 << 6)        /* LED Interrupt Mask 0:No mask, 1:mask         */
> +#define LED_EN	      (1 << 4) /* LED ON/OFF 0:off, 1:on	      */
> +#define LED_AUTOSTOP  (1 << 5) /* LED ON/OFF auto stop set 0:disable,1:enable*/
> +#define LED_ALWAYS    (1 << 6) /* LED Interrupt Mask 0:No mask, 1:mask	 */

Please keep comments ending in the same column.

>
>   static void micro_leds_brightness_set(struct led_classdev *led_cdev,
>   				      enum led_brightness value)
> @@ -27,14 +27,14 @@ static void micro_leds_brightness_set(struct led_classdev *led_cdev,
>   	/*
>   	 * In this message:
>   	 * Byte 0 = LED color: 0 = yellow, 1 = green
> -	 *          yellow LED is always ~30 blinks per minute
> +	 *	  yellow LED is always ~30 blinks per minute
>   	 * Byte 1 = duration (flags?) appears to be ignored
>   	 * Byte 2 = green ontime in 1/10 sec (deciseconds)
> -	 *          1 = 1/10 second
> -	 *          0 = 256/10 second
> +	 *	  1 = 1/10 second
> +	 *	  0 = 256/10 second
>   	 * Byte 3 = green offtime in 1/10 sec (deciseconds)
> -	 *          1 = 1/10 second
> -	 *          0 = 256/10 seconds
> +	 *	  1 = 1/10 second
> +	 *	  0 = 256/10 seconds
>   	 */
>   	struct ipaq_micro_msg msg = {
>   		.id = MSG_NOTIFY_LED,
> @@ -64,14 +64,14 @@ static int micro_leds_blink_set(struct led_classdev *led_cdev,
>   	/*
>   	 * In this message:
>   	 * Byte 0 = LED color: 0 = yellow, 1 = green
> -	 *          yellow LED is always ~30 blinks per minute
> +	 *	  yellow LED is always ~30 blinks per minute
>   	 * Byte 1 = duration (flags?) appears to be ignored
>   	 * Byte 2 = green ontime in 1/10 sec (deciseconds)
> -	 *          1 = 1/10 second
> -	 *          0 = 256/10 second
> +	 *	  1 = 1/10 second
> +	 *	  0 = 256/10 second
>   	 * Byte 3 = green offtime in 1/10 sec (deciseconds)
> -	 *          1 = 1/10 second
> -	 *          0 = 256/10 seconds
> +	 *	  1 = 1/10 second
> +	 *	  0 = 256/10 seconds
>   	 */

This looks worse after applying the patch. Why actually did you change
it? AFAICS checkpatch.pl doesn't complain here.

>   	struct ipaq_micro_msg msg = {
>   		.id = MSG_NOTIFY_LED,
> @@ -79,14 +79,14 @@ static int micro_leds_blink_set(struct led_classdev *led_cdev,
>   	};
>
>   	msg.tx_data[0] = LED_GREEN;
> -        if (*delay_on > IPAQ_LED_MAX_DUTY ||
> +	if (*delay_on > IPAQ_LED_MAX_DUTY ||
>   	    *delay_off > IPAQ_LED_MAX_DUTY)
> -                return -EINVAL;
> +		return -EINVAL;
>
> -        if (*delay_on == 0 && *delay_off == 0) {
> -                *delay_on = 100;
> -                *delay_off = 100;
> -        }
> +	if (*delay_on == 0 && *delay_off == 0) {
> +		*delay_on = 100;
> +		*delay_off = 100;
> +	}
>
>   	msg.tx_data[1] = 0;
>   	if (*delay_on >= IPAQ_LED_MAX_DUTY)
>


-- 
Best Regards,
Jacek Anaszewski
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/