lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 7 Sep 2015 14:16:15 -0300 From: Ezequiel Garcia <ezequiel@...guardiasur.com.ar> To: Alex Smith <alex.smith@...tec.com> Cc: "linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, Zubair Lutfullah Kakakhel <Zubair.Kakakhel@...tec.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Brian Norris <computersforpeace@...il.com>, David Woodhouse <dwmw2@...radead.org> Subject: Re: [PATCH v4 2/3] dt-bindings: binding for jz4780-{nand,bch} On 27 July 2015 at 10:50, Alex Smith <alex.smith@...tec.com> wrote: > Add DT bindings for NAND devices connected to the NEMC on JZ4780 SoCs, > as well as the hardware BCH controller, used by the jz4780_{nand,bch} > drivers. > > Signed-off-by: Alex Smith <alex.smith@...tec.com> > Cc: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@...tec.com> > Cc: David Woodhouse <dwmw2@...radead.org> > Cc: Brian Norris <computersforpeace@...il.com> > Cc: linux-mtd@...ts.infradead.org > Cc: devicetree@...r.kernel.org > Cc: linux-kernel@...r.kernel.org > --- > v3 -> v4: > - No change > > v2 -> v3: > - Rebase to 4.0-rc6 > - Changed ingenic,ecc-size to common nand-ecc-step-size > - Changed ingenic,ecc-strength to common nand-ecc-strength > - Changed ingenic,busy-gpio to common rb-gpios > - Changed ingenic,wp-gpio to common wp-gpios > > v1 -> v2: > - Rebase to 4.0-rc3 > --- > .../bindings/mtd/ingenic,jz4780-nand.txt | 57 ++++++++++++++++++++++ > 1 file changed, 57 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mtd/ingenic,jz4780-nand.txt > > diff --git a/Documentation/devicetree/bindings/mtd/ingenic,jz4780-nand.txt b/Documentation/devicetree/bindings/mtd/ingenic,jz4780-nand.txt > new file mode 100644 > index 000000000000..1e8e2eeffbf7 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mtd/ingenic,jz4780-nand.txt > @@ -0,0 +1,57 @@ > +* Ingenic JZ4780 NAND/BCH > + > +This file documents the device tree bindings for NAND flash devices on the > +JZ4780. NAND devices are connected to the NEMC controller (described in > +memory-controllers/ingenic,jz4780-nemc.txt), and thus NAND device nodes must > +be children of the NEMC node. > + > +Required NAND device properties: > +- compatible: Should be set to "ingenic,jz4780-nand". > +- reg: For each bank with a NAND chip attached, should specify a bank number, > + an offset of 0 and a size of 0x1000000 (i.e. the whole NEMC bank). > + > +Optional NAND device properties: > +- ingenic,bch-device: To make use of the hardware BCH controller, this property > + must contain a phandle for the BCH controller node. The required properties > + for this node are described below. If this is not specified, software BCH > + will be used instead. > +- nand-ecc-step-size: ECC block size in bytes. > +- nand-ecc-strength: ECC strength (max number of correctable bits). > +- rb-gpios: GPIO specifier for the busy pin. > +- wp-gpios: GPIO specifier for the write protect pin. > + > +Example: > + > +nemc: nemc@...10000 { > + ... > + > + nand: nand@1 { > + compatible = "ingenic,jz4780-nand"; > + reg = <1 0 0x1000000>; /* Bank 1 */ > + > + ingenic,bch-device = <&bch>; I believe it's slighly more common to use a -controller suffix for such a property: $ git grep "controller = <&" Documentation/devicetree/bindings/ Other than this, it looks good. -- Ezequiel GarcĂa, VanguardiaSur www.vanguardiasur.com.ar -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists