linux-kernel - Re: [PATCH v4 1/2] Add the driver of mbigen interrupt controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <55ECE58D.6050602@huawei.com>
Date:	Mon, 7 Sep 2015 09:17:01 +0800
From:	"majun (F)" <majun258@...wei.com>
To:	Alexey Klimov <klimov.linux@...il.com>
CC:	Catalin Marinas <Catalin.Marinas@....com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	Will Deacon <Will.Deacon@....com>,
	Mark Rutland <mark.rutland@....com>, <marc.zyngier@....com>,
	<jason@...edaemon.net>, Thomas Gleixner <tglx@...utronix.de>,
	<lizefan@...wei.com>, <huxinwei@...wei.com>,
	<dingtianhong@...wei.com>, <zhaojunhua@...ilicon.com>,
	Kenneth Lee <liguozhu@...ilicon.com>, <xuwei5@...ilicon.com>,
	<wei.chenwei@...ilicon.com>, <guohanjun@...wei.com>,
	<wuyun.wu@...wei.com>, Guodong Xu <guodong.xu@...aro.org>,
	Haojian Zhuang <haojian.zhuang@...aro.org>,
	Zhangfei Gao <zhangfei.gao@...aro.org>,
	"Usman Ahmad" <usman.ahmad@...aro.org>
Subject: Re: [PATCH v4 1/2] Add the driver of mbigen interrupt controller

Hi Alexey:

在 2015/9/4 8:56, Alexey Klimov 写道:
> Hi Ma Jun,
> 
> On Tue, Sep 1, 2015 at 4:45 AM, majun (F) <majun258@...wei.com> wrote:
>> Hi Alexey:
>>
[...]
>>>> +       mgn_chip->base = base;
>>>> +       mgn_chip->node = node;
>>>> +
>>>> +       domain = irq_domain_add_tree(node, &mbigen_domain_ops, mgn_chip);
>>>> +       mgn_chip->domain = domain;
>>>> +
>>>> +       raw_spin_lock_init(&mgn_chip->lock);
>>>> +       INIT_LIST_HEAD(&mgn_chip->entry);
>>>> +       INIT_LIST_HEAD(&mgn_chip->mbigen_device_list);
>>>> +
>>>> +       for_each_child_of_node(node, child) {
>>>> +               mbigen_device_init(mgn_chip, child);
>>>
>>> You don't check error from mbigen_device_init()
>> I don't think we need to check errors here.
>> mbigen_device_init() handle all errors.
> 
> For my eyes, mbigen_device_init() is static and used only once here.
> Here you don't check return value from it. If this is correct you can
> convert mbigen_device_init() to return void unless you have future
> plans to modify it.
> 
> Or you have option to check return value here and add error path.

Ok, This will be changed in next version.

> 
> Please add me to cc to next version of patch set which I guess will be v5.
> 

Got it. I will add you to cc list in next version.
Thanks for you review !

Ma Jun


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/