linux-kernel - Re: [PATCH 15/15] x86/headers: Remove <asm/sigcontext.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150907073750.GB19280@gmail.com>
Date:	Mon, 7 Sep 2015 09:37:50 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Mikko Rapeli <mikko.rapeli@....fi>
Cc:	linux-kernel@...r.kernel.org,
	Andy Lutomirski <luto@...capital.net>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Denys Vlasenko <dvlasenk@...hat.com>,
	Brian Gerst <brgerst@...il.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Borislav Petkov <bp@...en8.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Oleg Nesterov <oleg@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 15/15] x86/headers: Remove <asm/sigcontext.h>


* Mikko Rapeli <mikko.rapeli@....fi> wrote:

> > > +++ b/arch/x86/include/uapi/asm/sigcontext32.h
> > > @@ -3,6 +3,6 @@
> > >  
> > >  /* This is a legacy file - all the type definitions are in sigcontext.h: */
> > >  
> > > -#include <uapi/asm/sigcontext.h>
> > > +#include <asm/sigcontext.h>
> > 
> > There's no asm/sigcontext.h file anymore if you apply my patches - but we could 
> > reintroduce it to make the copy of UAPI headers to user-space work as-is.
> 
> Actually there is, in user space :)

I mean in the kernel arch/x86/include/asm/sigcontext.h is gone (at least in that 
series), we use the UAPI header directly.

> Then a nice solution would be for the kernel side wrapper to do like you
> said (on top of your changes on master):
> 
> --- /dev/null
> +++ b/arch/x86/include/asm/sigcontext.h
> @@ -0,0 +1,6 @@
> +#ifndef _ASM_X86_SIGCONTEXT_H
> +#define _ASM_X86_SIGCONTEXT_H
> +
> +#include <uapi/asm/sigcontext.h>
> +
> +#endif /* _ASM_X86_SIGCONTEXT_H */
> 
> And I guess logically this belongs to commit "x86/headers: Remove
> <asm/sigcontext.h>".

Yeah, will do this, plus some comments explaining that this is really just so that 
we can keep the UAPI side compatible with a 'straight user-space copying of the 
header files'.

This won't affect the kernel as we won't include asm/sigcontext.h directly. (And 
even if we do, there's no harm done.)

Agreed?

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/