linux-kernel - Re: [PATCH 6/6] ACPI / property: Extend device_get_next_child

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 8 Sep 2015 11:21:53 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	"Rafael J. Wysocki" <rjw@...ysocki.net>
Cc:	ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Darren Hart <darren.hart@...el.com>,
	Grant Likely <grant.likely@...aro.org>,
	Arnd Bergmann <arnd.bergmann@...aro.org>,
	David Woodhouse <dwmw2@...radead.org>,
	Dustin Byford <dustin@...ulusnetworks.com>,
	Alexandre Courbot <gnurou@...il.com>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>
Subject: Re: [PATCH 6/6] ACPI / property: Extend device_get_next_child_node()
 to data-only nodes

On Thu, Aug 27, 2015 at 4:42 AM, Rafael J. Wysocki <rjw@...ysocki.net> wrote:

> From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
>
> Make device_get_next_child_node() work with ACPI data-only subnodes
> introduced previously.
>
> Namely, replace acpi_get_next_child() with acpi_get_next_subnode()
> that can handle (and return) child device objects as well as child
> data-only subnodes of the given device and modify the ACPI part
> of the GPIO subsystem to handle data-only subnodes returned by it.
>
> To that end, introduce acpi_node_get_gpiod() taking a struct
> fwnode_handle pointer as the first argument.  That argument may
> point to an ACPI device object as well as to a data-only subnode
> and the function should do the right thing (ie. look for the matching
> GPIO descriptor correctly) in either case.
>
> Next, modify fwnode_get_named_gpiod() to use acpi_node_get_gpiod()
> instead of acpi_get_gpiod_by_index() which automatically causes
> devm_get_gpiod_from_child() to work with ACPI data-only subnodes
> that may be returned by device_get_next_child_node() which in turn
> is required by the users of that function (the gpio_keys_polled
> and gpio-leds drivers).
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> Tested-by: Mika Westerberg <mika.westerberg@...ux.intel.com>

Acked-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/