linux-kernel - Re: [PATCH] kernel/sysctl.c: If "count" including the terminating byte '\0' the write system call should retrun success.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150908111730.6a1ecca6@gandalf.local.home>
Date:	Tue, 8 Sep 2015 11:17:30 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Sean Fu <fxinrong@...il.com>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Austin S Hemmelgarn <ahferroin7@...il.com>,
	Andrey Ryabinin <ryabinin.a.a@...il.com>,
	Ulrich Obergfell <uobergfe@...hat.com>,
	Prarit Bhargava <prarit@...hat.com>,
	Eric B Munson <emunson@...mai.com>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	Johannes Weiner <hannes@...xchg.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Don Zickus <dzickus@...hat.com>,
	Heinrich Schuchardt <xypron.glpk@....de>,
	David Rientjes <rientjes@...gle.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kernel/sysctl.c: If "count" including the terminating
 byte '\0' the write system call should retrun success.

On Tue, 8 Sep 2015 11:11:38 +0800
Sean Fu <fxinrong@...il.com> wrote:

> On Fri, Aug 28, 2015 at 11:31 AM, Sean Fu <fxinrong@...il.com> wrote:
> > On Thu, Aug 27, 2015 at 4:32 PM, Sean Fu <fxinrong@...il.com> wrote:
> >> On Thu, Aug 27, 2015 at 10:32 AM, Steven Rostedt <rostedt@...dmis.org> wrote:
> >>> On Thu, 27 Aug 2015 08:17:29 +0800
> >>> Sean Fu <fxinrong@...il.com> wrote:
> >>>> strace execute result:
> >>>> write(3, "1\2\0", 3)                    = -1 EINVAL (Invalid argument)
> > If vleft > 1, "1\0 2" is treated as invalid paraments and all string
> > include '\0' will be invalid.
> Hi All experts,
> Could you please signed off this patch?

If anyone should take this, it would be Andrew.

I have no issue with the patch. Eric, you had some issue, but I don't
see a scenario that would depend on the current behavior. That is, what
do you think would break if we put it back to the old behavior?

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/