linux-kernel - Re: [PATCH 2/6] perf, tools, stat: Abstract stat metrics printing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150908160317.GF4524@tassilo.jf.intel.com>
Date:	Tue, 8 Sep 2015 09:03:17 -0700
From:	Andi Kleen <ak@...ux.intel.com>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	Andi Kleen <andi@...stfloor.org>, acme@...nel.org,
	jolsa@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/6] perf, tools, stat: Abstract stat metrics printing

>   - introduce the print_metrics interface for perf_stat__print_shadow_stats
>   - introduce printout function
>   - introduce support for printing metrics in csv in interval mode

That's already a separate patch.

>   - and enable i
> 
> 
> or any other way you find feasible *easy to review*.. I cannot ack it at this state

Well it's just printing out values. It's really not rocket science. Nobody
is asking you to review a new VM subsystems or something like that.

I expect each more "refactoring" to add more problems. It's just really hard to to do,
and usually adds more problems.

I can try one more time, but if it doesn't work out we'll have to give up on this.

-Andi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/