linux-kernel - Re: [PATCH v2] Cleanup: membarrier selftest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 8 Sep 2015 13:39:11 -0600
From:	Shuah Khan <shuahkh@....samsung.com>
To:	Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Cc:	linux-kernel@...r.kernel.org,
	Michael Ellerman <mpe@...erman.id.au>,
	linux-api@...r.kernel.org, Pranith Kumar <bobby.prani@...il.com>,
	Shuah Khan <shuahkh@....samsung.com>
Subject: Re: [PATCH v2] Cleanup: membarrier selftest

On 09/08/2015 01:21 PM, Mathieu Desnoyers wrote:
> As per Michael Ellerman's comments, we don't need to specify the rule
> in the Makefile, the implicit one will do the same. Also, the
> "__EXPORTED_HEADERS__" include is not needed, because we build the
> test against the installed kernel headers, not the kernel headers.
> Include <unistd.h> rather than the rather specific
> <asm-generic/unistd.h> (the former header is located in a standard
> location and includes the latter).
> 
> My own cleanups: re-use "$(TEST_PROGS)" in the clean target rather than
> spelling the executable twice. Include <syscall.h> rather than
> <sys/syscall.h> (the former header is located in a standard location
> and includes the latter).

Please refine this changelog. Reference to comments belongs in the
Changes since section. Please rephrase to not include reference to
comments. Please do the same for "My own cleanups:". Get rid of it.

thanks,
-- Shuah
> 
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
> CC: Michael Ellerman <mpe@...erman.id.au>
> CC: Andrew Morton <akpm@...ux-foundation.org>
> CC: linux-api@...r.kernel.org
> CC: Pranith Kumar <bobby.prani@...il.com>
> CC: Shuah Khan <shuahkh@....samsung.com>
> --
> Changes since v1:
> - Add Changelog.
> ---
>  tools/testing/selftests/membarrier/Makefile          | 7 +++----
>  tools/testing/selftests/membarrier/membarrier_test.c | 5 +----
>  2 files changed, 4 insertions(+), 8 deletions(-)
> 
> diff --git a/tools/testing/selftests/membarrier/Makefile b/tools/testing/selftests/membarrier/Makefile
> index 877a503..a1a9708 100644
> --- a/tools/testing/selftests/membarrier/Makefile
> +++ b/tools/testing/selftests/membarrier/Makefile
> @@ -1,11 +1,10 @@
>  CFLAGS += -g -I../../../../usr/include/
>  
> -all:
> -	$(CC) $(CFLAGS) membarrier_test.c -o membarrier_test
> -
>  TEST_PROGS := membarrier_test
>  
> +all: $(TEST_PROGS)
> +
>  include ../lib.mk
>  
>  clean:
> -	$(RM) membarrier_test
> +	$(RM) $(TEST_PROGS)
> diff --git a/tools/testing/selftests/membarrier/membarrier_test.c b/tools/testing/selftests/membarrier/membarrier_test.c
> index dde3125..535f0fe 100644
> --- a/tools/testing/selftests/membarrier/membarrier_test.c
> +++ b/tools/testing/selftests/membarrier/membarrier_test.c
> @@ -1,9 +1,6 @@
>  #define _GNU_SOURCE
> -#define __EXPORTED_HEADERS__
> -
>  #include <linux/membarrier.h>
> -#include <asm-generic/unistd.h>
> -#include <sys/syscall.h>
> +#include <syscall.h>
>  #include <stdio.h>
>  #include <errno.h>
>  #include <string.h>
> 


-- 
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@....samsung.com | (970) 217-8978
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/