linux-kernel - Re: [PATCH v2 4/6] selftests: mqueue: simpification the Makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1441691252.14597.14.camel@ellerman.id.au>
Date:	Tue, 08 Sep 2015 15:47:32 +1000
From:	Michael Ellerman <mpe@...erman.id.au>
To:	Bamvor Jian Zhang <bamvor.zhangjian@...aro.org>
Cc:	linux-kernel@...r.kernel.org, broonie@...nel.org,
	khilman@...aro.org, tyler.baker@...aro.org, shuahkh@....samsung.com
Subject: Re: [PATCH v2 4/6] selftests: mqueue: simpification the Makefile

On Mon, 2015-09-07 at 22:04 +0800, Bamvor Jian Zhang wrote:

> selftests: mqueue: simpification the Makefile

This should be:

selftests/mqueue: Simplify the Makefile


And please write a change log, even for simple commits like this.

You can say something like:

  Use make's implict rule for building simple C programs.

> Suggested-by: Michael Ellermani <mpe@...erman.id.au>
> Signed-off-by: Bamvor Jian Zhang <bamvor.zhangjian@...aro.org>
> ---
>  tools/testing/selftests/mqueue/Makefile | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/testing/selftests/mqueue/Makefile b/tools/testing/selftests/mqueue/Makefile
> index ca8327f..9f51aaa 100644
> --- a/tools/testing/selftests/mqueue/Makefile
> +++ b/tools/testing/selftests/mqueue/Makefile
> @@ -1,8 +1,7 @@
>  CFLAGS += -O2
> +LDLIBS = -lrt -lpthread -lpopt

Please move the TEST_PROGS line here:

TEST_PROGS := mq_open_tests mq_perf_tests

> -all:
> -	$(CC) $(CFLAGS) mq_open_tests.c -o mq_open_tests -lrt
> -	$(CC) $(CFLAGS) -o mq_perf_tests mq_perf_tests.c -lrt -lpthread -lpopt
> +all: mq_open_tests mq_perf_tests

So this can become:

all: $(TEST_PROGS)

>  
>  include ../lib.mk


cheers


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/