linux-kernel - Re: [tip:x86/headers] x86/headers: Remove <asm/sigcontext.h> references on the kernel side

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150908201725.GH9187@lakka.kapsi.fi>
Date:	Tue, 8 Sep 2015 23:17:25 +0300
From:	Mikko Rapeli <mikko.rapeli@....fi>
To:	tglx@...utronix.de, peterz@...radead.org, mingo@...nel.org,
	bp@...en8.de, dvlasenk@...hat.com, torvalds@...ux-foundation.org,
	linux-kernel@...r.kernel.org, brgerst@...il.com, oleg@...hat.com,
	hpa@...or.com, luto@...capital.net
Cc:	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:x86/headers] x86/headers: Remove <asm/sigcontext.h>
 references on the kernel side

Hi,

Tested these changes on top of my uapi headers fix branch and
they compile without problems in userspace and thus fix the original issue.

Also abi-compliance-checker reports that these changes don't break anything
in i386 ABI (details at [2]):

"Test Info
Library Name	kernel
Version #1	headers_test_v04
Version #2	headers_test_v04+test_ingo_x86_cleanup
CPU Type	x86
GCC Version	5.2.1
Subject	Binary Compatibility
Test Results
Total Header Files	767
Total Shared Libraries	0 (not analyzed)
Total Symbols / Types	62 / 67
Verdict	Compatible"

or API:

"Test Info
Library Name	kernel
Version #1	headers_test_v04
Version #2	headers_test_v04+test_ingo_x86_cleanup
CPU Type	x86
GCC Version	5.2.1
Subject	Source Compatibility
Test Results
Total Header Files	767
Total Shared Libraries	0 (not analyzed)
Total Symbols / Types	96 / 101
Verdict	Compatible"

While abi-compliance-checker is still quite broken with kernel header files[3]
addition of new constants was correctly detected:

"Other Changes in Constants (3)
sigcontext.h
[−] _fpstate
	Change	Effect
1	The constant _fpstate with value _fpstate_32 has been added.	No effect.

[−] _fpstate_ia32
	Change	Effect
1	The constant _fpstate_ia32 with value _fpstate_32 has been added.	No effect.

[−] sigcontext_ia32
	Change	Effect
1	The constant sigcontext_ia32 with value sigcontext_32 has been added.	No effect."

So for 32 bit userspace side

Tested-by: Mikko Rapeli <mikko.rapeli@....fi>

-Mikko

[1] http://lvc.github.io/abi-compliance-checker/

[2] API/ABI check results
    https://mcfrisk.kapsi.fi/temp/headers_test_v04_to_headers_test_v04+test_ingo_x86_cleanup/

[3] abi checker still has some issues with kernel headers:
    https://mcfrisk.kapsi.fi/temp/headers_test_v04+test_ingo_x86_cleanup/log.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/