linux-kernel - Re: [PATCH V2 1/2] efi: print unrecognized CPER section

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55EF59A9.2010905@codeaurora.org>
Date:	Tue, 08 Sep 2015 16:56:57 -0500
From:	Timur Tabi <timur@...eaurora.org>
To:	"Jonathan (Zhixiong) Zhang" <zjzhang@...eaurora.org>,
	Matt Fleming <matt.fleming@...el.com>, tony.luck@...el.com,
	fu.wei@...aro.org, al.stone@...aro.org, rjw@...ysocki.net,
	mchehab@....samsung.com, mingo@...hat.com, bp@...en8.de,
	gong.chen@...ux.intel.com
CC:	linux-efi@...r.kernel.org, linux-kernel@...r.kernel.org,
	linaro-acpi@...ts.linaro.org, vgandhi@...eaurora.org,
	linux-acpi@...r.kernel.org
Subject: Re: [PATCH V2 1/2] efi: print unrecognized CPER section

On 09/08/2015 04:29 PM, Jonathan (Zhixiong) Zhang wrote:

> Change-Id: I663a6e3ae6dcf68e4e389f76d555e9106ffee165

You need to strip out the Change-Id's before posting the patch.

> +#define cper_print_hex(pfx, buf, len)				\
> +	print_hex_dump(pfx, "",					\
> +		DUMP_PREFIX_OFFSET, ROW_SIZE, GROUP_SIZE,	\
> +		buf, len, 0)

		(buf), (len), 0)

is safer

> +	} else {
> +		const void *raw_err = gdata + 1;
> +		printk("%ssection type: %pUl\n", pfx, sec_type);
> +		printk("%ssection length: %d\n", pfx, len);
> +		cper_print_hex(newpfx, raw_err, len);

You don't need raw_err.  This should work fine:

		cper_print_hex(newpfx, gdata + 1, len);

-- 
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/