linux-kernel - Re: [PATCH RFC tip/core/rcu 3/9] rcu_sync: Add CONFIG_PROVE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150908233251.GC4029@linux.vnet.ibm.com>
Date:	Tue, 8 Sep 2015 16:32:51 -0700
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	Oleg Nesterov <oleg@...hat.com>
Cc:	Daniel Wagner <wagi@...om.org>, linux-kernel@...r.kernel.org,
	mingo@...nel.org, jiangshanlai@...il.com, dipankar@...ibm.com,
	akpm@...ux-foundation.org, mathieu.desnoyers@...icios.com,
	josh@...htriplett.org, tglx@...utronix.de, peterz@...radead.org,
	rostedt@...dmis.org, dhowells@...hat.com, edumazet@...gle.com,
	dvhart@...ux.intel.com, fweisbec@...il.com, bobby.prani@...il.com
Subject: Re: [PATCH RFC tip/core/rcu 3/9] rcu_sync: Add CONFIG_PROVE_RCU
 checks

On Mon, Sep 07, 2015 at 02:52:47PM +0200, Oleg Nesterov wrote:
> On 09/07, Daniel Wagner wrote:
> >
> > On 08/29/2015 05:35 AM, Paul E. McKenney wrote:
> > > +extern bool __rcu_sync_is_idle(struct rcu_sync *);
> > > +
> > >  /**
> > >   * rcu_sync_is_idle() - Are readers permitted to use their fastpaths?
> > >   * @rsp: Pointer to rcu_sync structure to use for synchronization
> > > @@ -50,7 +52,11 @@ struct rcu_sync {
> > >   */
> > >  static inline bool rcu_sync_is_idle(struct rcu_sync *rsp)
> > >  {
> > > +#ifdef CONFIG_PROVE_RCU
> > > +	return __rcu_sync_is_idle(rss);
> >
> > s/rss/rsp?
> 
> Hmm, yes.
> 
> Paul, it seems that you renamed "rss" to "rsp" globally (I didn't even
> notice this change), but forgot about this one ;)
> 
> Should I send the patch or will you fix this yourself?

I did fix it in -rcu, and a few other breakages as well.  Most of them
self-inflicted, as usual.  However, I am holding off on this series in
order to get it a bit more pre-merge testing.  I expect to push this
in v4.4.

							Thanx, Paul

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/