[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <55EE72B7.1060304@mellanox.com>
Date: Tue, 8 Sep 2015 08:31:35 +0300
From: Haggai Eran <haggaie@...lanox.com>
To: Parav Pandit <pandit.parav@...il.com>, <cgroups@...r.kernel.org>,
<linux-doc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<linux-rdma@...r.kernel.org>, <tj@...nel.org>,
<lizefan@...wei.com>, <hannes@...xchg.org>, <dledford@...hat.com>
CC: <corbet@....net>, <james.l.morris@...cle.com>, <serge@...lyn.com>,
<ogerlitz@...lanox.com>, <matanb@...lanox.com>,
<raindel@...lanox.com>, <akpm@...ux-foundation.org>,
<linux-security-module@...r.kernel.org>
Subject: Re: [PATCH 3/7] devcg: Added infrastructure for rdma device cgroup.
On 07/09/2015 23:38, Parav Pandit wrote:
> diff --git a/include/linux/device_cgroup.h b/include/linux/device_cgroup.h
> index 8b64221..cdbdd60 100644
> --- a/include/linux/device_cgroup.h
> +++ b/include/linux/device_cgroup.h
> @@ -1,6 +1,57 @@
> +#ifndef _DEVICE_CGROUP
> +#define _DEVICE_CGROUP
> +
> #include <linux/fs.h>
> +#include <linux/cgroup.h>
> +#include <linux/device_rdma_cgroup.h>
You cannot add this include line before adding the device_rdma_cgroup.h
(added in patch 5). You should reorder the patches so that after each
patch the kernel builds correctly.
I also noticed in patch 2 you add device_rdma_cgroup.o to the Makefile
before it was added to the kernel.
Regards,
Haggai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists