lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 9 Sep 2015 08:14:04 -0700 From: Alexei Starovoitov <alexei.starovoitov@...il.com> To: Tycho Andersen <tycho.andersen@...onical.com> Cc: Kees Cook <keescook@...omium.org>, "Michael Kerrisk (man-pages)" <mtk.manpages@...il.com>, Linux API <linux-api@...r.kernel.org>, Alexei Starovoitov <ast@...nel.org>, Will Drewry <wad@...omium.org>, Oleg Nesterov <oleg@...hat.com>, Andy Lutomirski <luto@...capital.net>, Pavel Emelyanov <xemul@...allels.com>, "Serge E. Hallyn" <serge.hallyn@...ntu.com>, Daniel Borkmann <daniel@...earbox.net>, LKML <linux-kernel@...r.kernel.org>, Network Development <netdev@...r.kernel.org> Subject: Re: [PATCH 5/6] seccomp: add a way to attach a filter via eBPF fd On Wed, Sep 09, 2015 at 08:47:24AM -0600, Tycho Andersen wrote: > On Tue, Sep 08, 2015 at 05:07:03PM -0700, Kees Cook wrote: > > > > Yeah, bpf's union looks good. Let's add a "command" flag, though: > > > > seccomp(SECCOMP_MODE_FILTER_EBPF, int cmd, union, size); > > > > And this cmd could be ADD_FD or something? > > > > How's that look? > > I think we can drop the size (using the same strategy as bpf() and > checking for zeroes at the end), and keep the same signature for > seccomp(); so: > > seccomp(SECCOMP_MODE_FILTER_EBPF, SECCOMP_ADD_BPF_FD, &union) > > Yes, I'll use this in the next version. actually bpf() has size as the last argument: SYSCALL_DEFINE3(bpf, int, cmd, union bpf_attr __user *, uattr, unsigned int, size) perf_event_open() doesn't and size is embedded as one of the fields. Both approaches are equivally powerfull from extensitiblity point of view. My preference was to keep size as an explicit argument. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists