linux-kernel - Re: [PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 9 Sep 2015 00:01:45 -0300
From:	Fabio Estevam <festevam@...il.com>
To:	Ramakrishna Pallala <ramakrishna.pallala@...el.com>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	Sebastian Reichel <sre@...nel.org>,
	Jenny TC <jenny.tc@...el.com>,
	Andreas Dannenberg <dannenberg@...com>
Subject: Re: [PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

On Sun, Sep 6, 2015 at 2:23 PM, Ramakrishna Pallala
<ramakrishna.pallala@...el.com> wrote:

> +       chip->psy_usb = power_supply_register(&client->dev,
> +                               &bq24261_charger_desc, &charger_cfg);
> +       if (IS_ERR(chip->psy_usb)) {
> +               dev_err(&client->dev,
> +                       "power supply registration failed(%d)\n", ret);
> +               return ret;

You should not print and return ret here.

You should print and return IS_ERR(chip->psy_usb) instead.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/