linux-kernel - Re: [PATCH] staging: slicoss: remove unused variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 9 Sep 2015 11:31:37 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:	Lior Dotan <liodot@...il.com>,
	Christopher Harrer <charrer@...critech.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: slicoss: remove unused variables

On Fri, Sep 04, 2015 at 06:53:18PM +0530, Sudip Mukherjee wrote:
> These variables were only assigned some values but they were never used.
> 
> Signed-off-by: Sudip Mukherjee <sudip@...torindia.org>
> ---
>  drivers/staging/slicoss/slicoss.c | 27 ++++++---------------------
>  1 file changed, 6 insertions(+), 21 deletions(-)
> 
> diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c
> index 8585970..1536ca0 100644
> --- a/drivers/staging/slicoss/slicoss.c
> +++ b/drivers/staging/slicoss/slicoss.c
> @@ -199,10 +199,8 @@ static void slic_mcast_set_mask(struct adapter *adapter)
>  static void slic_timer_ping(ulong dev)
>  {
>  	struct adapter *adapter;
> -	struct sliccard *card;
>  
>  	adapter = netdev_priv((struct net_device *)dev);
> -	card = adapter->card;
>  
>  	adapter->pingtimer.expires = jiffies + (PING_TIMER_INTERVAL * HZ);
>  	add_timer(&adapter->pingtimer);
> @@ -1719,7 +1717,6 @@ static u32 slic_rcvqueue_reinsert(struct adapter *adapter, struct sk_buff *skb)
>   */
>  static void slic_link_event_handler(struct adapter *adapter)
>  {
> -	int status;
>  	struct slic_shmem *pshmem;
>  
>  	if (adapter->state != ADAPT_UP) {
> @@ -1730,15 +1727,13 @@ static void slic_link_event_handler(struct adapter *adapter)
>  	pshmem = (struct slic_shmem *)(unsigned long)adapter->phys_shmem;
>  
>  #if BITS_PER_LONG == 64
> -	status = slic_upr_request(adapter,
> -				  SLIC_UPR_RLSR,
> -				  SLIC_GET_ADDR_LOW(&pshmem->linkstatus),
> -				  SLIC_GET_ADDR_HIGH(&pshmem->linkstatus),
> -				  0, 0);
> +	slic_upr_request(adapter, SLIC_UPR_RLSR,
> +			 SLIC_GET_ADDR_LOW(&pshmem->linkstatus),
> +			 SLIC_GET_ADDR_HIGH(&pshmem->linkstatus), 0, 0);
>  #else
> -	status = slic_upr_request(adapter, SLIC_UPR_RLSR,
> -		(u32) &pshmem->linkstatus,	/* no 4GB wrap guaranteed */
> -				  0, 0, 0);
> +	slic_upr_request(adapter, SLIC_UPR_RLSR,
> +			 (u32)&pshmem->linkstatus, /* no 4GB wrap guaranteed */
> +			 0, 0, 0);

Shouldn't we do something with status instead of just ignoring it?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/