lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 8 Sep 2015 20:29:24 -0500 From: Rob Herring <robh@...nel.org> To: Tomeu Vizoso <tomeu.vizoso@...labora.com>, linux-kernel@...r.kernel.org Cc: Stephen Warren <swarren@...dotorg.org>, Javier Martinez Canillas <javier@....samsung.com>, Mark Brown <broonie@...nel.org>, Thierry Reding <thierry.reding@...il.com>, "Rafael J. Wysocki" <rjw@...ysocki.net>, linux-arm-kernel@...ts.infradead.org, Dmitry Torokhov <dmitry.torokhov@...il.com>, devicetree@...r.kernel.org, Linus Walleij <linus.walleij@...aro.org>, linux-acpi@...r.kernel.org, Arnd Bergmann <arnd@...db.de>, Frank Rowand <frowand.list@...il.com>, Grant Likely <grant.likely@...aro.org> Subject: Re: [PATCH v4 04/22] of: add function to allow probing a device from a OF node On 09/07/2015 07:23 AM, Tomeu Vizoso wrote: > Walks the OF tree up and finds the closest ancestor that has a struct > device associated with it, probing it if isn't bound to a driver yet. > > The above should ensure that the dependency represented by the passed OF > node is available, because probing a device should cause its descendants > to be probed as well (when they get registered). > > Subsystems can use this when looking up resources for drivers, to reduce > the chances of deferred probes because of the probing order of devices. > > Signed-off-by: Tomeu Vizoso <tomeu.vizoso@...labora.com> Looks pretty good to me. One comment below. [...] > diff --git a/drivers/of/platform.c b/drivers/of/platform.c > index baf04d7249bd..f089d95ac961 100644 > --- a/drivers/of/platform.c > +++ b/drivers/of/platform.c > @@ -269,6 +269,8 @@ static struct amba_device *of_amba_device_create(struct device_node *node, > goto err_free; > } > > + node->device = &dev->dev; > + This seems oddly placed. Can you move to patch 3? > return dev; > > err_free: > diff --git a/include/linux/of_device.h b/include/linux/of_device.h > index cc7dd687a89d..da8d489e73ad 100644 > --- a/include/linux/of_device.h > +++ b/include/linux/of_device.h > @@ -40,6 +40,7 @@ extern ssize_t of_device_get_modalias(struct device *dev, > > extern void of_device_uevent(struct device *dev, struct kobj_uevent_env *env); > extern int of_device_uevent_modalias(struct device *dev, struct kobj_uevent_env *env); > +extern void of_device_probe(struct device_node *np); > > static inline void of_device_node_put(struct device *dev) > { > @@ -84,6 +85,8 @@ static inline int of_device_uevent_modalias(struct device *dev, > return -ENODEV; > } > > +static inline void of_device_probe(struct device_node *np) { } > + > static inline void of_device_node_put(struct device *dev) { } > > static inline const struct of_device_id *__of_match_device( > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists