linux-kernel - RE: [PATCH] thermal: Fix thermal_zone_of_sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <744357E9AAD1214791ACBA4B0B9092631DD4BF06@SHSMSX101.ccr.corp.intel.com>
Date:	Thu, 10 Sep 2015 08:44:05 +0000
From:	"Zhang, Rui" <rui.zhang@...el.com>
To:	Javi Merino <javi.merino@....com>,
	Punit Agrawal <punit.agrawal@....com>
CC:	"edubezval@...il.com" <edubezval@...il.com>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux@...ck-us.net" <linux@...ck-us.net>
Subject: RE: [PATCH] thermal: Fix thermal_zone_of_sensor_register to match
 documentation



> -----Original Message-----
> From: Javi Merino [mailto:javi.merino@....com]
> Sent: Thursday, September 10, 2015 4:39 PM
> To: Punit Agrawal
> Cc: edubezval@...il.com; Zhang, Rui; linux-pm@...r.kernel.org; linux-
> kernel@...r.kernel.org; linux@...ck-us.net
> Subject: Re: [PATCH] thermal: Fix thermal_zone_of_sensor_register to
> match documentation
> Importance: High
> 
> On Tue, Sep 08, 2015 at 02:51:12PM +0100, Punit Agrawal wrote:
> > thermal_zone_of_sensor_register is documented as returning a pointer
> > to either a valid thermal_zone_device on success, or a corresponding
> > ERR_PTR() value.
> >
> > In contrast, the function returns NULL when THERMAL_OF is configured
> > off. Fix this.
> >
> > Signed-off-by: Punit Agrawal <punit.agrawal@....com>
> > Acked-by: Guenter Roeck <linux@...ck-us.net>
> > Cc: Eduardo Valentin <edubezval@...il.com>
> > Cc: Zhang Rui <rui.zhang@...el.com>
> > ---
> > Hi Eduardo, Rui,
> >
> > This patch has been on the list without any objection for sometime [0]
> > now. Could you pick this up for the next rc please?
> >
Will apply after 4.3-rc1 merge window closed.

Thanks,
rui
> > Thanks,
> > Punit
> >
> > [0] http://thread.gmane.org/gmane.linux.kernel/2011466/focus=2013175
> >
> >  include/linux/thermal.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> FWIW,
> 
> Reviewed-by: Javi Merino <javi.merino@....com>
> 
> Cheers,
> Javi
> 
> > diff --git a/include/linux/thermal.h b/include/linux/thermal.h index
> > 037e9df..f344e51 100644
> > --- a/include/linux/thermal.h
> > +++ b/include/linux/thermal.h
> > @@ -364,7 +364,7 @@ static inline struct thermal_zone_device *
> > thermal_zone_of_sensor_register(struct device *dev, int id, void *data,
> >  				const struct thermal_zone_of_device_ops
> *ops)  {
> > -	return NULL;
> > +	return ERR_PTR(-ENODEV);
> >  }
> >
> >  static inline
> > --
> > 2.5.0