linux-kernel - Re: [PATCH V2 2/2] ras: acpi / apei: generate trace event for unrecognized CPER section

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150910184136.GC10457@pd.tnic>
Date:	Thu, 10 Sep 2015 20:41:36 +0200
From:	Borislav Petkov <bp@...en8.de>
To:	"Jonathan (Zhixiong) Zhang" <zjzhang@...eaurora.org>
Cc:	Matt Fleming <matt.fleming@...el.com>, tony.luck@...el.com,
	fu.wei@...aro.org, al.stone@...aro.org, rjw@...ysocki.net,
	mchehab@....samsung.com, mingo@...hat.com,
	gong.chen@...ux.intel.com, linux-efi@...r.kernel.org,
	linux-kernel@...r.kernel.org, linaro-acpi@...ts.linaro.org,
	vgandhi@...eaurora.org, linux-acpi@...r.kernel.org,
	timur@...eaurora.org
Subject: Re: [PATCH V2 2/2] ras: acpi / apei: generate trace event for
 unrecognized CPER section

On Tue, Sep 08, 2015 at 02:29:21PM -0700, Jonathan (Zhixiong) Zhang wrote:
>  /*
> + * Raw Events Report
> + *
> + * This event is generated when hardware detected a hardware
> + * error event, which may be of non-standard section as defined
> + * in UEFI spec appendix "Common Platform Error Record", or may
> + * be of sections for which TRACE_EVENT is not defined.
> + *
> + */
> +TRACE_EVENT(raw_event,
> +
> +	TP_PROTO(const uuid_le *sec_type,
> +		 const uuid_le *fru_id,
> +		 const char *fru_text,
> +		 u8 sev,
> +		 const u8 *err,
> +		 const u32 len),

This is not a raw event - this is an event which has a section type, FRU
ID, text, etc, etc.

A raw event is one which takes exactly two arguments: bytes and count.
What it does is, it dumps the bytes of length count in a block or other
amicably formatted output, most likely hex, similar to hexdump or other
tools; *without* any attempt to interpret it whatsoever.

Its *consumers* do the interpretation. So that that raw_event tracepoint
can be used as a fallback in all cases where the error information is of
unknown structure to the kernel.

Btw, @count should be sanity-checked before calling the tracepoint with
insane values.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/