linux-kernel - RE: [PATCH 04/13] perf env: Introduce read_cpu_topology

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <37D7C6CF3E00A74B8858931C1DB2F0770192290F@SHSMSX103.ccr.corp.intel.com>
Date:	Thu, 10 Sep 2015 20:14:08 +0000
From:	"Liang, Kan" <kan.liang@...el.com>
To:	Arnaldo Carvalho de Melo <acme@...nel.org>
CC:	Ingo Molnar <mingo@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Hunter, Adrian" <adrian.hunter@...el.com>,
	Borislav Petkov <bp@...e.de>, David Ahern <dsahern@...il.com>,
	"Frederic Weisbecker" <fweisbec@...il.com>,
	Jiri Olsa <jolsa@...hat.com>,
	Namhyung Kim <namhyung@...nel.org>,
	Stephane Eranian <eranian@...gle.com>,
	Wang Nan <wangnan0@...wei.com>
Subject: RE: [PATCH 04/13] perf env: Introduce read_cpu_topology_map() method



> Em Thu, Sep 10, 2015 at 08:00:54PM +0000, Liang, Kan escreveu:
> > > Em Wed, Sep 09, 2015 at 09:41:18PM +0000, Liang, Kan escreveu:
> > > > > -	for (i = 0; i < tp->cpu_nr; i++) {
> > > > > -		ret = do_write(fd, &tp->core_id[i], sizeof(int));
> > > > > +	perf_env__read_cpu_topology_map(&perf_env);
> > > > > +
> 
> > > > I think we need to handle error here.
> 
> > > Ok, adding a test, updated patch below. While doing that, noticed
> > > that the in the thread_sib case the "ret = do_something()" doesn't
> > > makes the whole function fail, will fix later.
> 
> > Except patch 11 & 13 (for reverting), the rest of patches are good to me.
> 
> Ok, so, to take it more formally, can I turn this "good to me" as justification
> for adding "Acked-by: Kan Liang", to those patches?

Yes.

> 
> Please take a look at the other patches in the perf/env branch, I did it while
> trying to figure it out if the reverts should be kept.
>
OK

Thanks,
Kan
 
> - Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/