[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-id: <55F28C20.2080800@samsung.com>
Date: Fri, 11 Sep 2015 17:09:04 +0900
From: Chanwoo Choi <cw00.choi@...sung.com>
To: Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>,
lee.jones@...aro.org
Cc: myungjoo.ham@...sung.com, sameo@...ux.intel.com,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
patches@...nsource.wolfsonmicro.com
Subject: Re: [PATCH 6/6] mfd: arizona: Update DT binding documentation for jack
detection
On 2015년 09월 10일 20:41, Charles Keepax wrote:
> Add additional bindings for both inverting the polarity of the jack
> detection pins and allowing the use of a second jack detection pin. Note
> that the second jack detection pin is hard wired in the chip so can only
> be enabled through the binding, rather than a pin being specified.
>
> Signed-off-by: Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
> ---
> Documentation/devicetree/bindings/mfd/arizona.txt | 6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/arizona.txt b/Documentation/devicetree/bindings/mfd/arizona.txt
> index b98a11b..48bca6a 100644
> --- a/Documentation/devicetree/bindings/mfd/arizona.txt
> +++ b/Documentation/devicetree/bindings/mfd/arizona.txt
> @@ -73,6 +73,12 @@ Optional properties:
> If this node is not mentioned or if the value is unknown, then
> headphone detection mode is set to HPDETL.
>
> + - wlf,use-jd-gpio : Use GPIO input alongwith JD1 for dual pin jack
s/alongwith/along with
> + detection.
> + - wlf,use-jd-gpio-nopull : Internal pull on GPIO is disabled when used for
> + jack detection.
> + - wlf,jd-invert : Invert the polarity of the jack detection switch
> +
> - wlf,micd-software-compare : Use a software comparison to determine mic
> presence
> - wlf,micd-detect-debounce : Additional software microphone detection
>
If you fixes the minor typo, looks good to me.
Reviewed-by: Chanwoo Choi <cw00.choi@...sung.com>
Thanks,
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists