linux-kernel - Re: [PATCH V2 3/3] reset: hi6220: Reset driver for hisilicon hi6220 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2464506.5Jp1Wg3qfc@wuerfel>
Date:	Fri, 11 Sep 2015 10:41:24 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Chen Feng <puck.chen@...ilicon.com>
Cc:	p.zabel@...gutronix.de, linux-kernel@...r.kernel.org,
	robh+dt@...nel.org, pawel.moll@....com, xuwei5@...ilicon.com,
	haojian.zhuang@...aro.org, zhangfei.gao@...mail.com,
	xuyiping@...ilicon.com, bintian.wang@...wei.com,
	devicetree@...r.kernel.org, dan.zhao@...ilicon.com,
	suzhuangluan@...ilicon.com, w.f@...wei.com
Subject: Re: [PATCH V2 3/3] reset: hi6220: Reset driver for hisilicon hi6220 SoC

On Friday 11 September 2015 16:18:38 Chen Feng wrote:
> +static int __init hi6220_reset_init(void)
> +{
> +	int ret;
> +	struct device_node *np;
> +	struct hi6220_reset_data *data;
> +
> +	data = kzalloc(sizeof(*data), GFP_KERNEL);
> +	if (!data)
> +		return -ENOMEM;
> +
> +	np = of_find_compatible_node(NULL, NULL, "hisilicon,hi6220_reset_ctl");
> +	if (!np) {
> +		ret = -ENXIO;
> +		goto err_alloc;
> +	}

Why is this not a platform driver?

> +	if (IS_ENABLED(CONFIG_RESET_CONTROLLER))
> +		reset_controller_register(&data->rc_dev);
> +
> +	return 0;

The Kconfig symbol already depends on RESET_CONTROLLER, so
the IS_ENABLED() check looks redundant.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/