linux-kernel - Re: [PATCH 2/3] ibmvcsci: display default value for max_id, max_lun and max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150911105339.67ab9c5f@voom.fritz.box>
Date:	Fri, 11 Sep 2015 10:53:39 +1000
From:	David Gibson <dgibson@...hat.com>
To:	Laurent Vivier <lvivier@...hat.com>
Cc:	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
	"James E.J. Bottomley" <JBottomley@...n.com>,
	Tyrel Datwyler <tyreld@...ux.vnet.ibm.com>, thuth@...hat.com,
	pbonzini@...hat.com
Subject: Re: [PATCH 2/3] ibmvcsci: display default value for max_id, max_lun
 and max_channel.

On Thu, 10 Sep 2015 11:23:13 +0200
Laurent Vivier <lvivier@...hat.com> wrote:

> As devices with values greater than that are silently ignored,
> this gives some hints to the sys admin to know why he doesn't see
> his devices...
> 
> Signed-off-by: Laurent Vivier <lvivier@...hat.com>

Reviewed-by: David Gibson <david@...son.dropbear.id.au>

> ---
>  drivers/scsi/ibmvscsi/ibmvscsi.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c
> index 3e76490..f9d7ec4 100644
> --- a/drivers/scsi/ibmvscsi/ibmvscsi.c
> +++ b/drivers/scsi/ibmvscsi/ibmvscsi.c
> @@ -106,9 +106,9 @@ MODULE_LICENSE("GPL");
>  MODULE_VERSION(IBMVSCSI_VERSION);
>  
>  module_param_named(max_id, max_id, int, S_IRUGO);
> -MODULE_PARM_DESC(max_id, "Largest ID value for each channel");
> +MODULE_PARM_DESC(max_id, "Largest ID value for each channel [Default=64]");
>  module_param_named(max_channel, max_channel, int, S_IRUGO);
> -MODULE_PARM_DESC(max_channel, "Largest channel value");
> +MODULE_PARM_DESC(max_channel, "Largest channel value [Default=3]");
>  module_param_named(init_timeout, init_timeout, int, S_IRUGO | S_IWUSR);
>  MODULE_PARM_DESC(init_timeout, "Initialization timeout in seconds");
>  module_param_named(max_requests, max_requests, int, S_IRUGO);
> @@ -2294,6 +2294,10 @@ static int ibmvscsi_probe(struct vio_dev *vdev, const struct vio_device_id *id)
>  	host->max_channel = max_channel;
>  	host->max_cmd_len = 16;
>  
> +	dev_info(dev,
> +		 "Maximum ID: %d Maximum LUN: %d Maximum Channel: %d\n",
> +		 host->max_id, host->max_lun, host->max_channel);
> +
>  	if (scsi_add_host(hostdata->host, hostdata->dev))
>  		goto add_host_failed;
>  
> -- 
> 2.1.0
> 


-- 
David Gibson <dgibson@...hat.com>
Senior Software Engineer, Virtualization, Red Hat

Content of type "application/pgp-signature" skipped