linux-kernel - Re: cpufreq: mediatek: allow modular build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150911095820.GM21084@n2100.arm.linux.org.uk>
Date:	Fri, 11 Sep 2015 10:58:20 +0100
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Viresh Kumar <viresh.kumar@...aro.org>
Cc:	Arnd Bergmann <arnd@...db.de>,
	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
	Pi-Cheng Chen <pi-cheng.chen@...aro.org>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: cpufreq: mediatek: allow modular build

On Fri, Sep 11, 2015 at 03:10:03PM +0530, Viresh Kumar wrote:
> On 11-09-15, 10:34, Russell King - ARM Linux wrote:
> > Well, that's got nothing to do with not having a module_exit().
> 
> Yeah, so we don't necessarily need a module_exit(), but the module
> should have freed the resources with module unplug. And that was
> missing with Arnd's patch..

Not module "unplug" (I've never heard it called that before).  A module
with a module_init() but no module_exit() can only be added to a running
kernel, and never removed.  That's intentional behaviour.

However, if you're talking about hot-unplug, presumably you're talking
about _CPU_ hot-unplug, and that's something the code should definitely
handle irrespective of whether it's built-in or a module.

The two issues are entirely separate.

-- 
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/