linux-kernel - Re: [PATCH 1/5] staging: wilc1000: host_interface.c: replace WILC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 11 Sep 2015 16:25:57 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	Mike Rapoport <mike.rapoport@...il.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Johnny Kim <johnny.kim@...el.com>,
	Rachel Kim <rachel.kim@...el.com>,
	Chris Park <chris.park@...el.com>,
	Tony Cho <tony.cho@...el.com>, Glen Lee <glen.lee@...el.com>,
	Leo Kim <leo.kim@...el.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/5] staging: wilc1000: host_interface.c: replace
 WILC_MALLOC with kmalloc

On Thu, Sep 10, 2015 at 01:27:53PM +0300, Mike Rapoport wrote:
> WILC_MALLOC(size) is wrapping a call to kmalloc(size, GFP_ATOMIC) with a
> check for 'size > 0', which kmalloc handles anyway
> 
> The semantic patch that makes this change is as follows:
> 
> @@
> expression v, s;
> type t;
> identifier i;
> @@
> (
> - v = WILC_MALLOC(s);
> + v = kmalloc(s, GFP_ATOMIC);
> |
> - t i = WILC_MALLOC(s);
> + t i = kmalloc(s, GFP_ATOMIC);
> )
> 
> Signed-off-by: Mike Rapoport <mike.rapoport@...il.com>
> ---
Have you checked if it will be GFP_ATOMIC or GFP_KERNEL?
I think I can see many places where it will be GFP_KERNEL.

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/