linux-kernel - RE: Chipidea ULPI driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <F1B223389110CE49B4CF055ABA2E5D3D78C813D4@XAP-PVEXMBX01.xlnx.xilinx.com>
Date:	Fri, 11 Sep 2015 11:34:10 +0000
From:	Subbaraya Sundeep Bhatta <subbaraya.sundeep.bhatta@...inx.com>
To:	Peter Chen <peter.chen@...escale.com>,
	Punnaiah Choudary Kalluri <punnaia@...inx.com>
CC:	"balbi@...com" <balbi@...com>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Greg Kroah-Hartman (gregkh@...uxfoundation.org)" 
	<gregkh@...uxfoundation.org>, "kishon@...com" <kishon@...com>
Subject: RE: Chipidea ULPI driver

Hi,

> -----Original Message-----
> From: Peter Chen [mailto:peter.chen@...escale.com]
> Sent: Friday, September 11, 2015 6:52 AM
> To: Punnaiah Choudary Kalluri
> Cc: balbi@...com; Subbaraya Sundeep Bhatta; linux-usb@...r.kernel.org; linux-
> kernel@...r.kernel.org; Greg Kroah-Hartman (gregkh@...uxfoundation.org);
> kishon@...com
> Subject: Re: Chipidea ULPI driver
> 
> On Thu, Sep 10, 2015 at 02:57:49PM +0000, Punnaiah Choudary Kalluri wrote:
> >
> >
> > > -----Original Message-----
> > > From: Felipe Balbi [mailto:balbi@...com]
> > > Sent: Thursday, September 10, 2015 8:14 PM
> > > To: Subbaraya Sundeep Bhatta
> > > Cc: Peter Chen; balbi@...com; linux-usb@...r.kernel.org; linux-
> > > kernel@...r.kernel.org; Greg Kroah-Hartman
> > > (gregkh@...uxfoundation.org); kishon@...com; Punnaiah Choudary
> > > Kalluri
> > > Subject: Re: Chipidea ULPI driver
> > >
> > > (break your lines at 80-characters)
> > >
> > > On Thu, Sep 10, 2015 at 12:44:58PM +0000, Subbaraya Sundeep Bhatta
> wrote:
> > > > Hi Peter,
> > > >
> > > > We are using NOP transceiver driver for USB3320 ULPI PHY with
> > > > ChipIdea controller.
> > > >
> > > > Recently we found that one of the boards (zedboard) requires PHY
> > > > register access to set VBUS.
> > > >
> > > > Note that our local driver we had before migrating to ChipIdea
> > > > driver calls otg_ulpi_create with flags  ULPI_OTG_DRVVBUS |
> > > > ULPI_OTG_DRVVBUS_EXT so that VBUS is enabled at initialization.
> > > >
> > > > Can you please let me know how to do this with ChipIdea case? I
> > > > see the following solutions:
> > > >
> > > > 1. Write ULPI driver for USB3320 similar to tusb1210.
> > >
> > > this
> >
> > How about extending the phy-ulpi driver to use it as platform driver?
> > So that boards that are using the ulpi compatible phy and driving vbus
> > from the phy can use this driver.
> >
> 
> Yes, you can improve phy-ulpi driver, and it can not depend on NOP transceiver
> driver.

AFAIK phy-ulpi.c is just exporting functions and not registering to platform
bus since it is not connected to SOC bus. I don't think we can create platform
driver for this. I have read TUSB1210 data sheet and it is similar to USB3320
with no additional SOC bus connection and has only ULPI interface. 
So it should register to ULPI bus which is in kernel recently. I will make
changes to chipidea similar to dwc3(adding ulpi.c) and write driver similar
to tusb1210.c. Is that okay?

Thanks,
Sundeep

> 
> --
> 
> Best Regards,
> Peter Chen
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/