linux-kernel - Re: [PATCH] ALSA: hdsp: fix memory leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hlhcd6ka7.wl-tiwai@suse.de>
Date:	Fri, 11 Sep 2015 17:35:44 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	"Sudip Mukherjee" <sudipm.mukherjee@...il.com>
Cc:	"Jaroslav Kysela" <perex@...ex.cz>, <alsa-devel@...a-project.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ALSA: hdsp: fix memory leak

On Fri, 11 Sep 2015 15:40:38 +0200,
Sudip Mukherjee wrote:
> 
> If the size of the firmware is less than expected size then we are
> exiting with the error code but we missed releasing the firmware.
> 
> Signed-off-by: Sudip Mukherjee <sudip@...torindia.org>

Applied, thanks.


Takashi

> ---
>  sound/pci/rme9652/hdsp.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/pci/rme9652/hdsp.c b/sound/pci/rme9652/hdsp.c
> index 9bba275..2875b4f 100644
> --- a/sound/pci/rme9652/hdsp.c
> +++ b/sound/pci/rme9652/hdsp.c
> @@ -5112,6 +5112,7 @@ static int hdsp_request_fw_loader(struct hdsp *hdsp)
>  		dev_err(hdsp->card->dev,
>  			"too short firmware size %d (expected %d)\n",
>  			   (int)fw->size, HDSP_FIRMWARE_SIZE);
> +		release_firmware(fw);
>  		return -EINVAL;
>  	}
>  
> -- 
> 1.9.1
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/