linux-kernel - Re: [PATCH 10/16] Staging: lustre: obdclass: genops.c: Remove explicit NULL comparison

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1441939867.15135.2.camel@perches.com>
Date:	Thu, 10 Sep 2015 19:51:07 -0700
From:	Joe Perches <joe@...ches.com>
To:	Shraddha Barke <shraddha.6596@...il.com>
Cc:	Oleg Drokin <oleg.drokin@...el.com>,
	Andreas Dilger <andreas.dilger@...el.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Julia Lawall <Julia.Lawall@...6.fr>, HPDD-discuss@...ts.01.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 10/16] Staging: lustre: obdclass: genops.c: Remove
 explicit NULL comparison

On Fri, 2015-09-11 at 07:34 +0530, Shraddha Barke wrote:
> Remove explicit NULL comparison and write it in its simpler form.
> Replacement done with coccinelle:

Hi Shraddha.

If you are going to do these conversions, please
also do the equivalent != NULL conversions:

- e != NULL
+ e

> diff --git a/drivers/staging/lustre/lustre/obdclass/genops.c b/drivers/staging/lustre/lustre/obdclass/genops.c
[]
> @@ -178,9 +178,9 @@ int class_register_type(struct obd_ops *dt_ops, struct md_ops *md_ops,
> -	if (type->typ_dt_ops == NULL ||
> -	    type->typ_md_ops == NULL ||
> -	    type->typ_name == NULL)
> +	if (!type->typ_dt_ops ||
> +	    !type->typ_md_ops ||
> +	    !type->typ_name)


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/