| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20150911.161856.1635045038995107888.davem@davemloft.net> Date: Fri, 11 Sep 2015 16:18:56 -0700 (PDT) From: David Miller <davem@...emloft.net> To: khoroshilov@...ras.ru Cc: samuel@...tiz.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, ldv-project@...uxtesting.org Subject: Re: [PATCH] irda: ali-ircc: Fix deadlock in ali_ircc_sir_change_speed() From: Alexey Khoroshilov <khoroshilov@...ras.ru> Date: Sat, 12 Sep 2015 00:34:48 +0300 > ali_ircc_sir_change_speed() is always called with self->lock held, > so acquiring the lock inside it leads to unavoidable deadlock. > > Call graph: > ali_ircc_sir_change_speed() is called from ali_ircc_change_speed() > ali_ircc_fir_hard_xmit() under spin_lock_irqsave(&self->lock, flags); > ali_ircc_sir_hard_xmit() under spin_lock_irqsave(&self->lock, flags); > ali_ircc_net_ioctl() under spin_lock_irqsave(&self->lock, flags); > ali_ircc_dma_xmit_complete() > ali_ircc_fir_interrupt() > ali_ircc_interrupt() under spin_lock(&self->lock); > ali_ircc_sir_write_wakeup() > ali_ircc_sir_interrupt() > ali_ircc_interrupt() under spin_lock(&self->lock); > > The patch removes spin_lock/unlock from ali_ircc_sir_change_speed(). > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov <khoroshilov@...ras.ru> Looks good, applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists