linux-kernel - [PATCH v2 2/4] Staging: vt6656: Bool tests don't need comparisons

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1442055931-6056-2-git-send-email-shraddha.6596@gmail.com>
Date:	Sat, 12 Sep 2015 16:35:29 +0530
From:	Shraddha Barke <shraddha.6596@...il.com>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jes Sorensen <Jes.Sorensen@...hat.com>,
	Julia Lawall <julia.lawall@...6.fr>,
	linux-kernel@...r.kernel.org
Cc:	Shraddha Barke <shraddha.6596@...il.com>
Subject: [PATCH v2 2/4] Staging: vt6656: Bool tests don't need comparisons

This patch removes comparisons to true/false values on bool variables.
Fix made using Coccinelle

Change in v2-
 Fixing logical error

Signed-off-by: Shraddha Barke <shraddha.6596@...il.com>
---
 drivers/staging/vt6656/wcmd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/vt6656/wcmd.c b/drivers/staging/vt6656/wcmd.c
index 3cbf479..c8e69ff 100644
--- a/drivers/staging/vt6656/wcmd.c
+++ b/drivers/staging/vt6656/wcmd.c
@@ -177,7 +177,7 @@ int vnt_schedule_command(struct vnt_private *priv, enum vnt_cmd command)
 	ADD_ONE_WITH_WRAP_AROUND(priv->cmd_enqueue_idx, CMD_Q_SIZE);
 	priv->free_cmd_queue--;
 
-	if (priv->cmd_running == false)
+	if (!priv->cmd_running)
 		vnt_cmd_complete(priv);
 
 	return true;
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/