linux-kernel - Re: [PATCH v2 3/4] Staging: rtl8712: Bool tests don't need comparisons

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 12 Sep 2015 17:20:36 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	Shraddha Barke <shraddha.6596@...il.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jes Sorensen <Jes.Sorensen@...hat.com>,
	Julia Lawall <julia.lawall@...6.fr>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/4] Staging: rtl8712: Bool tests don't need
 comparisons

On Sat, Sep 12, 2015 at 04:35:30PM +0530, Shraddha Barke wrote:
> This patch removes comparisons to true/false values on bool variables.
> Fix made using Coccinelle
> 
> Changes in v2-
>  More instances covered
> 
> Signed-off-by: Shraddha Barke <shraddha.6596@...il.com>
> ---
You have not even build tested before sending.
>  drivers/staging/rtl8712/rtl871x_ioctl_set.c | 24 ++++-----
>  drivers/staging/rtl8712/rtl871x_mlme.c      | 77 ++++++++++++++---------------
>  2 files changed, 50 insertions(+), 51 deletions(-)
<snip>	
> 
> @@ -1131,9 +1130,9 @@ int r8712_select_and_join_from_scan(struct mlme_priv *pmlmepriv)
>  	phead = &queue->queue;
>  	pmlmepriv->pscanned = phead->next;
>  	while (1) {
> -		if (end_of_queue_search(phead, pmlmepriv->pscanned) == true) {
> -			if ((pmlmepriv->assoc_by_rssi == true) &&
> -			    (pnetwork_max_rssi != NULL)) {
> +		if (end_of_queue_search(phead, pmlmepriv->pscanned)) {
> +			if ((pmlmepriv->assoc_by_rssi) &&
> +			    (pnetwork_max_rssi))
Coccinelle will not remove the opening brace.

And in one part of the patch one test for !=NULL was modified.

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/