linux-kernel - Re: [PATCH 4/6] Staging: iio: cdc: Prefer using the BIT macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20150912154905.GC29944@kroah.com>
Date:	Sat, 12 Sep 2015 08:49:05 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Shraddha Barke <shraddha.6596@...il.com>
Cc:	Jonathan Cameron <jic23@...nel.org>,
	Julia Lawall <julia.lawall@...6.fr>,
	Hartmut Knaack <knaack.h@....de>,
	Andreas Dilger <andreas.dilger@...el.com>,
	Ian Abbott <abbotti@....co.uk>, linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/6] Staging: iio: cdc: Prefer using the BIT macro

On Sat, Sep 12, 2015 at 04:47:23PM +0530, Shraddha Barke wrote:
> 
> 
> On Sat, Sep 12, 2015 at 3:17 PM, Jonathan Cameron <jic23@...nel.org> wrote:
> 
>     On 10/09/15 17:32, Shraddha Barke wrote:
>     > This patch replaces bit shifting on 1 with the BIT(x) macro
>     >
>     > This was done with coccinelle:
>     > @@ int g; @@
>     >
>     > -(1 << g)
>     > +BIT(g)
>     >
>     > Signed-off-by: Shraddha Barke <shraddha.6596@...il.com>
>     Something odd happened here as this is only a small proportion of the cases
>     that should be updated in this file.  There's one at the bottom of the
>     patch for starters!
> 
> 
> I didn't apply BIT(x) for mixed cases.I think I should drop this patch
> altogether but
> Greg has added it. Will it cause problems ? :(

Greg can always drop it :)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/