linux-kernel - drivers/misc/mei/hbm.c:1212: bad if test ?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <DUB128-W327463AAE9DB2506C326009C5F0@phx.gbl>
Date:	Sat, 12 Sep 2015 03:34:58 +0000
From:	David Binderman <dcb314@...mail.com>
To:	"tomas.winkler@...el.com" <tomas.winkler@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: drivers/misc/mei/hbm.c:1212: bad if test ?

Hello there,

drivers/misc/mei/hbm.c:1212:46: warning: logical ‘and’ of mutually exclusive tests is always false [-Wlogical-op]

Source code is

        if (dev->hbm_state <= MEI_HBM_ENUM_CLIENTS &&
            dev->hbm_state>= MEI_HBM_STOPPED) {

Maybe better code

        if (dev->hbm_state <= MEI_HBM_ENUM_CLIENTS ||
            dev->hbm_state>= MEI_HBM_STOPPED) {


Regards

David Binderman
 		 	   		  --
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/