linux-kernel - Re: [PATCH] staging: speakup: Changed simple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150912025700.GA17805@kroah.com>
Date:	Fri, 11 Sep 2015 19:57:00 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Aparna Karuthodi <kdasaparna@...il.com>
Cc:	kirk@...sers.ca, linux-kernel@...r.kernel.org,
	devel@...verdev.osuosl.org, speakup@...ux-speakup.org
Subject: Re: [PATCH] staging: speakup: Changed simple_strtoul to kstrtoul

On Fri, Sep 11, 2015 at 08:47:20PM +0530, Aparna Karuthodi wrote:
> Used kstrtoul instead of simple_strtoul to remove a warning detected by
> checkpatch.The warning is given below:
> drivers/staging/speakup/varhandlers.c:327: WARNING: simple_strtoul is
> obsolete, use kstrtoul instead
> 
> Signed-off-by: Aparna Karuthodi <kdasaparna@...il.com>
> ---
>  drivers/staging/speakup/varhandlers.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/speakup/varhandlers.c b/drivers/staging/speakup/varhandlers.c
> index 1b0d1c0..00fd67e 100644
> --- a/drivers/staging/speakup/varhandlers.c
> +++ b/drivers/staging/speakup/varhandlers.c
> @@ -324,7 +324,7 @@ char *spk_s2uchar(char *start, char *dest)
>  {
>  	int val = 0;
>  
> -	val = simple_strtoul(skip_spaces(start), &start, 10);
> +	val = kstrtoul(skip_spaces(start), &start, 10);
>  	if (*start == ',')
>  		start++;
>  	*dest = (u_char)val;

You obviously did not even compile this patch, which is quite rude,
don't you think?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/