linux-kernel - Re: [PATCH 1/2] btrfs: avoid passing int param to start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150913183437.GA24975@gmail.com>
Date:	Sun, 13 Sep 2015 18:34:37 +0000
From:	Alexandru Moise <00moses.alexander00@...il.com>
To:	Holger Hoffstätte 
	<holger.hoffstaette@...glemail.com>
Cc:	clm@...com, jbacik@...com, dsterba@...e.com,
	linux-btrfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] btrfs: avoid passing int param to start_transaction
 which takes u64

On Sun, Sep 13, 2015 at 02:53:14PM +0000, Holger Hoffstätte wrote:
> On Sun, 13 Sep 2015 14:29:41 +0000, Alexandru Moise wrote:
> 
> > Signed-off-by: Alexandru Moise <00moses.alexander00@...il.com>
> > ---
> >  fs/btrfs/transaction.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/fs/btrfs/transaction.c b/fs/btrfs/transaction.c
> > index 8f259b3..8a83acd 100644
> > --- a/fs/btrfs/transaction.c
> > +++ b/fs/btrfs/transaction.c
> > @@ -570,7 +570,7 @@ reserve_fail:
> >  }
> >  
> >  struct btrfs_trans_handle *btrfs_start_transaction(struct btrfs_root *root,
> > -						   int num_items)
> > +						   u64 num_items)
> >  {
> >  	return start_transaction(root, num_items, TRANS_START,
> >  				 BTRFS_RESERVE_FLUSH_ALL);
> 
> So I tried to build this..you won't believe what happened next:
> 
>   CC [M]  fs/btrfs/transaction.o
> fs/btrfs/transaction.c:570:28: error: conflicting types for 'btrfs_start_transaction'
>  struct btrfs_trans_handle *btrfs_start_transaction(struct btrfs_root *root,
>                             ^
> In file included from fs/btrfs/transaction.c:28:0:
> fs/btrfs/transaction.h:186:28: note: previous declaration of 'btrfs_start_transaction' was here
>  struct btrfs_trans_handle *btrfs_start_transaction(struct btrfs_root *root,
>                             ^
> scripts/Makefile.build:258: recipe for target 'fs/btrfs/transaction.o' failed
> 
> You need to update transaction.h as well.

The heck? I pulled from linus' tree earlier today and it built, I'll check again.
Thanks for telling me.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/