linux-kernel - RE: [PATCH v3] ahci: qoriq: fixed using uninitialized variable warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DM2PR03MB574C0A381BDAC53ED35F932FA5D0@DM2PR03MB574.namprd03.prod.outlook.com>
Date:	Mon, 14 Sep 2015 07:21:04 +0000
From:	Yuantian Tang <Yuantian.Tang@...escale.com>
To:	Yuantian Tang <Yuantian.Tang@...escale.com>,
	"hdegoede@...hat.com" <hdegoede@...hat.com>
CC:	"tj@...nel.org" <tj@...nel.org>,
	"fengguang.wu@...el.com" <fengguang.wu@...el.com>,
	"linux-ide@...r.kernel.org" <linux-ide@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v3] ahci: qoriq: fixed using uninitialized variable
 warnings

Hi Tejun, Fengguang,

Please help to verify if this patch can remove the warnings.

Thanks,
Yuantian

> -----Original Message-----
> From: Yuantian.Tang@...escale.com [mailto:Yuantian.Tang@...escale.com]
> Sent: Monday, September 14, 2015 3:13 PM
> To: hdegoede@...hat.com
> Cc: tj@...nel.org; fengguang.wu@...el.com; linux-ide@...r.kernel.org;
> linux-kernel@...r.kernel.org; Tang Yuantian-B29983
> <Yuantian.Tang@...escale.com>
> Subject: [PATCH v3] ahci: qoriq: fixed using uninitialized variable warnings
> 
> From: Tang Yuantian <Yuantian.Tang@...escale.com>
> 
> kbuild test robot reports the warnings:
> drivers/ata/ahci_qoriq.c: In function 'ahci_qoriq_hardreset':
> >> include/asm-generic/io.h:163:2: warning: 'px_is' may be used
> >> uninitialized in this function [-Wuninitialized]
> drivers/ata/ahci_qoriq.c:70:14: note: 'px_is' was declared here
> >> include/asm-generic/io.h:163:2: warning: 'px_cmd' may be used
> >> uninitialized in this function [-Wuninitialized]
> drivers/ata/ahci_qoriq.c:70:6: note: 'px_cmd' was declared here
> 
> This is caused by openrisc arch's compiler. This driver is for QorIQ ARM
> platforms. So add the dependency on ARM to remove these warnings.
> 
> Signed-off-by: Tang Yuantian <Yuantian.Tang@...escale.com>
> ---
> v3:
> 	- fix it by in a new way
> v2:
> 	- try another way to fix the warnings
> 	- remove clean up code
> 
>  drivers/ata/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig index 6aaa3f8..a830344
> 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -177,7 +177,7 @@ config AHCI_XGENE
> 
>  config AHCI_QORIQ
>  	tristate "Freescale QorIQ AHCI SATA support"
> -	depends on OF
> +	depends on OF && ARM
>  	help
>  	  This option enables support for the Freescale QorIQ AHCI SoC's
>  	  onboard AHCI SATA.
> --
> 2.1.0.27.g96db324

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/