linux-kernel - Re: [PATCH 05/10] ALSA: axd: add buffers manipulation files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55F68F5E.3050609@imgtec.com>
Date:	Mon, 14 Sep 2015 10:11:58 +0100
From:	Qais Yousef <qais.yousef@...tec.com>
To:	Mark Brown <broonie@...nel.org>
CC:	<alsa-devel@...a-project.org>, Liam Girdwood <lgirdwood@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 05/10] ALSA: axd: add buffers manipulation files

On 09/03/2015 01:32 PM, Mark Brown wrote:
> On Tue, Sep 01, 2015 at 11:00:42AM +0100, Qais Yousef wrote:
>> On 08/29/2015 10:47 AM, Mark Brown wrote:
> Please delete unneeded context from replies, it makes it easier to find
> the new content you have added.  Please also leave blank lines between
> paragraphs, it makes it much easier to read messages.


Sorry about that and for the delayed response. I added one more blank line now, hopefully this looks better.

  

>> to the driver that it can reuse it, there's no guarantee that this returned
>> buffer is in the same order it was sent.
> If that's the case I'm not sure the code is correct - it seemed to have
> assumptions that the buffers were going to be retired in the order.


What this code is trying to do is the same as what vring do. I'll move 
this driver to be rproc based which hopefully should make things simpler 
and trim all of this out and address your other review comments as well.

I didn't write an rproc driver before, if there's anything that you 
think I need to be aware of when writing an rproc based *ALSA* driver 
I'd appreciate pointing it out.

Thanks,
Qais
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/