linux-kernel - Re: [PATCH] x86, perf, uncore: Don't make MSR uncore depend on PCI uncore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.11.1509141143430.3971@nanos>
Date:	Mon, 14 Sep 2015 11:44:39 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Andi Kleen <andi@...stfloor.org>
cc:	peterz@...radead.org, linux-kernel@...r.kernel.org,
	Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH] x86, perf, uncore: Don't make MSR uncore depend on PCI
 uncore

On Wed, 9 Sep 2015, Andi Kleen wrote:
> --- a/arch/x86/kernel/cpu/perf_event_intel_uncore.c
> +++ b/arch/x86/kernel/cpu/perf_event_intel_uncore.c
> @@ -958,6 +958,8 @@ static void __init uncore_pci_exit(void)
>  		uncore_types_exit(uncore_pci_uncores);
>  	}
>  }
> +module_exit(uncore_pci_exit);
> +/* XXX: need exit code for rest of intel_uncore_init too */

That comment makes no sense at all.
  
Other than that:

Reviewed-by: Thomas Gleixner <tglx@...utronix.de>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/