linux-kernel - Re: [PATCH 00/15] [v4] x86, fpu: XSAVE cleanups and sanity checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 14 Sep 2015 12:07:36 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Dave Hansen <dave@...1.net>
Cc:	mingo@...hat.com, x86@...nel.org, bp@...en8.de,
	fenghua.yu@...el.com, tim.c.chen@...ux.intel.com,
	linux-kernel@...r.kernel.org,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andy Lutomirski <luto@...nel.org>,
	Denys Vlasenko <dvlasenk@...hat.com>,
	Brian Gerst <brgerst@...il.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Thomas Gleixner <tglx@...utronix.de>,
	Oleg Nesterov <oleg@...hat.com>
Subject: Re: [PATCH 00/15] [v4] x86, fpu: XSAVE cleanups and sanity checks


* Dave Hansen <dave@...1.net> wrote:

> Changes in v4:
>  * Fix up a few compile errors/warnings
> 
> Changes in v3:
>  * rework XSTATE_* macros using Ingo's suggested naming
>  * change state size printk to be in decimal
>  * add some more sanity-checking to detect and work around
>    an undersized 'xregs_state'
>  * remove "nr_" from some of the names used.
> 
> Changes in v2:
>  * remove references to Processor Trace XSAVE state
>    (will defer to another patch set)
>  * Remove some cruft from last patch
>  * move last_good_offset fix in to the patch that
>    introduced it
> 
> These patches make some updates to the x86 XSAVE code.
> 
> They have been build and boot tested including on hardware
> and/or simulators with AVX-512 and MPX.  It boots in all
> of the tested configurations without hitting any of the
> new warnings in this code.  I even added the Memory
> Protecion Keys (the xfeature after MPX) patches on top of
> this and everything works fine.
> 
> There are basically 5 things going on here:
>  * removal of the LWP (lightweight profiling) code
>  * naming and type cleanups
>  * removal of xfeatures_nr variable
>  * addition of AVX-512 C structures
>  * new sanity checks of XSAVE buffer sizing

Ok, very nice! I've applied your series to tip:x86/fpu and will push it out unless 
testing finds any problems.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/