linux-kernel - Re: [PATCH 2/4] ARM: sun8i: Add the A33 AHB1 gates clock driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150914144040.GD4684@lukather>
Date:	Mon, 14 Sep 2015 16:40:40 +0200
From:	Maxime Ripard <maxime.ripard@...e-electrons.com>
To:	Peter Korsgaard <peter@...sgaard.com>
Cc:	Emilio Lopez <emilio@...pez.com.ar>,
	Mike Turquette <mturquette@...libre.com>,
	Stephen Boyd <sboyd@...eaurora.org>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-clk@...r.kernel.org
Subject: Re: [PATCH 2/4] ARM: sun8i: Add the A33 AHB1 gates clock driver

Hi Peter,

On Sun, Sep 13, 2015 at 05:13:12PM +0200, Peter Korsgaard wrote:
> >>>>> "Maxime" == Maxime Ripard <maxime.ripard@...e-electrons.com> writes:
> 
>  > The A33 has different a different gates array than the A23, add the node to
>  > the DT.
> 
> NIT: 2x different.

Ah, good catch, thanks!

> Shouldn't the a23 one then move from sun8i-a23-a33.dtsi to
> sun8i-a23.dtsi?

It is, but in order to preserve bisectability, I declared the A33 node
first, that has precedence over the A23 still in the common DTSI, and
removed the A23 in the next patch.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)