linux-kernel - Re: [PATCH] serial: sccnxp: convert devm irq to non devm version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOMZO5BPUPW_DerteqxjMLRn-y8jaw149-3ogeq7OHO6uS=TFg@mail.gmail.com>
Date:	Mon, 14 Sep 2015 13:19:22 -0300
From:	Fabio Estevam <festevam@...il.com>
To:	Julia Lawall <Julia.Lawall@...6.fr>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	kernel-janitors@...r.kernel.org, Jiri Slaby <jslaby@...e.com>,
	"linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] serial: sccnxp: convert devm irq to non devm version

On Sun, Sep 13, 2015 at 10:44 AM, Julia Lawall <Julia.Lawall@...6.fr> wrote:

> --- a/drivers/tty/serial/sccnxp.c
> +++ b/drivers/tty/serial/sccnxp.c
> @@ -963,11 +963,9 @@ static int sccnxp_probe(struct platform_device *pdev)
>         sccnxp_write(&s->port[0], SCCNXP_IMR_REG, 0);
>
>         if (!s->poll) {
> -               ret = devm_request_threaded_irq(&pdev->dev, s->irq, NULL,
> -                                               sccnxp_ist,
> -                                               IRQF_TRIGGER_FALLING |
> -                                               IRQF_ONESHOT,
> -                                               dev_name(&pdev->dev), s);
> +               ret = request_threaded_irq(s->irq, NULL, sccnxp_ist,
> +                                          IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
> +                                          dev_name(&pdev->dev), s);
>                 if (!ret)
>                         return 0;
>
> @@ -994,7 +992,7 @@ static int sccnxp_remove(struct platform_device *pdev)
>         struct sccnxp_port *s = platform_get_drvdata(pdev);
>
>         if (!s->poll)
> -               devm_free_irq(&pdev->dev, s->irq, s);
> +               free_irq(s->irq, s);

Couldn't we just remove the devm_free_irq() and keep using
devm_request_threaded_irq()?

Like this:

--- a/drivers/tty/serial/sccnxp.c
+++ b/drivers/tty/serial/sccnxp.c
@@ -993,9 +993,7 @@ static int sccnxp_remove(struct platform_device *pdev)
        int i;
        struct sccnxp_port *s = platform_get_drvdata(pdev);

-       if (!s->poll)
-               devm_free_irq(&pdev->dev, s->irq, s);
-       else
+       if (s->poll)
                del_timer_sync(&s->timer);

        for (i = 0; i < s->uart.nr; i++)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/