lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 14 Sep 2015 19:05:47 +0200 From: Oleg Nesterov <oleg@...hat.com> To: "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com> Cc: Will Deacon <will.deacon@....com>, hpa@...or.com, luto@...capital.net, dave.hansen@...ux.intel.com, mingo@...e.hu, minchan@...nel.org, tglx@...utronix.de, linux-mm@...ck.org, linux-kernel@...r.kernel.org Subject: Re: LTP regressions due to 6dc296e7df4c ("mm: make sure all file VMAs have ->vm_ops set") On 09/14, Kirill A. Shutemov wrote: > > Fix is below. I don't really like it, but I cannot find any better > solution. Me too... But this change "documents" the nasty special "vm_file && !vm_ops" case, and I am not sure how we can remove it later... So perhaps we should change vma_is_anonymous() back to check ->fault too, static inline bool vma_is_anonymous(struct vm_area_struct *vma) { - return !vma->vm_ops; + return !vma->vm_ops || !vma->vm_ops->fault; } and remove the "vma->vm_file && !vma->vm_ops" checks in mmap_region() paths. I dunno. Oleg. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists