linux-kernel - Re: [PATCH 02/39] nilfs2: drop null test before destroy functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 14 Sep 2015 12:29:06 +0900 (JST)
From:	Ryusuke Konishi <konishi.ryusuke@....ntt.co.jp>
To:	Julia Lawall <Julia.Lawall@...6.fr>
Cc:	sergey.senozhatsky@...il.com, kernel-janitors@...r.kernel.org,
	linux-nilfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 02/39] nilfs2: drop null test before destroy functions

On Sun, 13 Sep 2015 14:14:55 +0200, Julia Lawall <Julia.Lawall@...6.fr> wrote:
> Remove unneeded NULL test.
> 
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @@ expression x; @@
> -if (x != NULL)
>   \(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x);
> // </smpl>
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>

Looks OK.  I'll queue this in my tree.

Thanks,
Ryusuke Konishi

> 
> ---
>  fs/nilfs2/super.c |   12 ++++--------
>  1 file changed, 4 insertions(+), 8 deletions(-)
> 
> diff --git a/fs/nilfs2/super.c b/fs/nilfs2/super.c
> index f47585b..c69455a 100644
> --- a/fs/nilfs2/super.c
> +++ b/fs/nilfs2/super.c
> @@ -1405,14 +1405,10 @@ static void nilfs_destroy_cachep(void)
>  	 */
>  	rcu_barrier();
>  
> -	if (nilfs_inode_cachep)
> -		kmem_cache_destroy(nilfs_inode_cachep);
> -	if (nilfs_transaction_cachep)
> -		kmem_cache_destroy(nilfs_transaction_cachep);
> -	if (nilfs_segbuf_cachep)
> -		kmem_cache_destroy(nilfs_segbuf_cachep);
> -	if (nilfs_btree_path_cache)
> -		kmem_cache_destroy(nilfs_btree_path_cache);
> +	kmem_cache_destroy(nilfs_inode_cachep);
> +	kmem_cache_destroy(nilfs_transaction_cachep);
> +	kmem_cache_destroy(nilfs_segbuf_cachep);
> +	kmem_cache_destroy(nilfs_btree_path_cache);
>  }
>  
>  static int __init nilfs_init_cachep(void)
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/