linux-kernel - Re: [PATCH] staging/rtl8192u: remove unused function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE_Gge18tWXc2WC=xUV+VU6mVDbHAGweDt5w__qOoEsogq1hWQ@mail.gmail.com>
Date:	Mon, 14 Sep 2015 14:25:42 -0400
From:	Raphaël Beamonte <raphael.beamonte@...il.com>
To:	Nicolas Joseph <nicolas.joseph@...ecomputing.fr>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Cristina Opriceana <cristina.opriceana@...il.com>,
	Luis de Bethencourt <luis@...ethencourt.com>,
	Koray Gulcu <koray.gulcu@....edu.tr>,
	Aya Mahfouz <mahfouz.saif.elyazal@...il.com>,
	devel@...verdev.osuosl.org, lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging/rtl8192u: remove unused function

2015-09-14 14:00 GMT-04:00 Nicolas Joseph <nicolas.joseph@...ecomputing.fr>:
> Remove N_DBPSOfRate used in ComputeTxTime, remove by
> commit 742728f97a99 ("staging: rtl8192u: remove unused function.")
>
> Signed-off-by: Nicolas Joseph <nicolas.joseph@...ecomputing.fr>
> ---
>  drivers/staging/rtl8192u/r8192U_core.c | 44 ----------------------------------
>  1 file changed, 44 deletions(-)
>
> diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c
> index b143b36..80a6a4f 100644
> --- a/drivers/staging/rtl8192u/r8192U_core.c
> +++ b/drivers/staging/rtl8192u/r8192U_core.c
> @@ -1227,50 +1227,6 @@ inline u8 rtl8192_IsWirelessBMode(u16 rate)
>                 return 0;
>  }
>
> -u16 N_DBPSOfRate(u16 DataRate)
> -{
> -       u16 N_DBPS = 24;
> -
> -       switch (DataRate) {
> -       case 60:
> -               N_DBPS = 24;
> -               break;
> -
> -       case 90:
> -               N_DBPS = 36;
> -               break;
> -
> -       case 120:
> -               N_DBPS = 48;
> -               break;
> -
> -       case 180:
> -               N_DBPS = 72;
> -               break;
> -
> -       case 240:
> -               N_DBPS = 96;
> -               break;
> -
> -       case 360:
> -               N_DBPS = 144;
> -               break;
> -
> -       case 480:
> -               N_DBPS = 192;
> -               break;
> -
> -       case 540:
> -               N_DBPS = 216;
> -               break;
> -
> -       default:
> -               break;
> -       }
> -
> -       return N_DBPS;
> -}
> -
>  short rtl819xU_tx_cmd(struct net_device *dev, struct sk_buff *skb)
>  {
>         struct r8192_priv *priv = ieee80211_priv(dev);
> --
> 2.5.2
>

Not sure the commit message is really clear. Something like this seems
more clean to me:
"Remove unused function N_DBPSOfRate. This function was only
used by function ComputeTxTime that was removed in a previous
commit."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/